Skip to content

Stream.pipeline does not re-emit errors without callback #20303

Description

@phated
  • Version:
    Node 10
  • Platform:
  • Subsystem:

Stream.pipeline doesn't re-emit errors when no callback is given. I opened this issue (mafintosh/pump#32) on pump before it was ported here but it was ignored.

Activity

  1. added
    streamIssues and PRs related to Node.js streams.
    on Apr 25, 2018
  2. changed the title [-]Stream.pipeline shipped with a huge bug?[/-] [+]Stream.pipeline does not re-emit errors without callback[/+] on Apr 25, 2018
  3. addaleax commented on Apr 25, 2018

    @addaleax
    Member

    You already seem to have a PR for this, would you be willing to port that?

  4. phated commented on Apr 25, 2018

    @phated
    ContributorAuthor

    Yeah, I can try. I might have some time later today.

  5. phated commented on Apr 26, 2018

    @phated
    ContributorAuthor

    @addaleax working on a PR now but it seems that I can't run the test suite without xcode 😞

  6. addaleax commented on Apr 27, 2018

    @addaleax
    Member

    @phated If it would be easier for you if somebody else took this over at some point, I think that wouldn’t be an issue either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    streamIssues and PRs related to Node.js streams.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions