Skip to content

test: investigate flakiness of test-net-write-after-close #13597

Description

@refack
  • Version: master
  • Platform: freeBSD
  • Subsystem: test,net
985	parallel/test-net-write-after-close	
duration_ms	60.143
severity	fail
stack	timeout

https://ci.nodejs.org/job/node-test-commit-freebsd/9623/nodes=freebsd10-64/tapResults/

Activity

added
netIssues and PRs related to the net subsystem.
testIssues and PRs related to Node.js core tests and test infrastructure.
on Jun 10, 2017
changed the title [-]test: investigate falkiness of [/-] [+]test: investigate flakiness of test-net-write-after-close[/+] on Jun 10, 2017

MylesBorins commented on Jul 18, 2017

@MylesBorins
Contributor

I'm seeing this rear its head in v6.x now

not ok 828 parallel/test-net-write-after-close
  ---
  duration_ms: 60.80
  severity: fail
  stack: |-
    timeout
  ...

Should we add to known flakes?

refack commented on Jul 18, 2017

@refack
ContributorAuthor

/cc @nodejs/platform-freebsd @nodejs/streams

Trott commented on Jul 19, 2017

@Trott
Member

Looks like it's the usual thing with FreeBSD flakes in CI, which is a race condition triggered by load.

If you shorten the hardcoded 250ms timeout, you can trigger the race faster/easier.

Source of the problem seems to be that the connection callback can fire after 250ms on a loaded machine.

PR coming shortly to fix this...

Trott commented on Jul 19, 2017

@Trott
Member

Proposed fix in #14361

refack commented on Jul 19, 2017

@refack
ContributorAuthor

Looks like it's the usual thing with FreeBSD flakes in CI, which is a race condition triggered by load.

If you shorten the hardcoded 250ms timeout, you can trigger the race faster/easier.

Source of the problem seems to be that the connection callback can fire after 250ms on a loaded machine.

PR coming shortly to fix this...

Should we start a "raw numbers to common.platformTimeout" tracking issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    netIssues and PRs related to the net subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions