Skip to content

--max-executable-size not recognized after upgrade 7.10.0 => 8.0.0 #13341

Closed
Closed
--max-executable-size not recognized after upgrade 7.10.0 => 8.0.0#13341
Labels
cliIssues and PRs related to the Node.js command-line interface.v8 engineIssues and PRs related to the V8 dependency.

Description

@abenhamdine
abenhamdine
opened on May 31, 2017
  • Version:8.0.0
  • Platform:Windows 10 64bits
  • Subsystem: child process

The following code doesn't crash with node 7.10.0 but crashes with node 8.0.0 :

            const env = _.cloneDeep(process.env);

            const options = {
                execArgv: process.execArgv.concat(['--expose-gc', '--max-executable-size=384', '--max-old-space-size=512', '--max-semi-space-size=2']),
                env: env
            };

            const cp = child_process.fork(myPathProcess, [someArg1, someArg2], options);

The error :

C:\Program Files\nodejs\node.exe: bad option: --max-executable-size=384

DEBUG 19:38:55 : Calculation.onChildExit() : child process 7016 exited with code 9

I've suspected #12348 but failed to see how it can be related.

Have the V8 options changed ? I didn't find anything in the changelog about this.
Or is --max-executable-size the correct syntax ?

Activity

  1. mscdex
    added
    cliIssues and PRs related to the Node.js command-line interface.
    v8 engineIssues and PRs related to the V8 dependency.
    v8.x
    on May 31, 2017

  2. targos commented on May 31, 2017

    @targos
    targos
    on May 31, 2017
    Member

    This flag was removed in #13217 (commit).

  3. silverwind commented on May 31, 2017

    @silverwind
    silverwind
    on May 31, 2017
    Contributor

    The new option for that should be --max_old_space_size.

  4. abenhamdine commented on May 31, 2017

    @abenhamdine
    abenhamdine
    on May 31, 2017
    Author

    Ah thx a lot for the quick and precise answer !
    Shouldn't it be in the changelog for 8.0.0 ?
    Seems pretty common case to use this flag.

  5. bnoordhuis commented on May 31, 2017

    @bnoordhuis
    bnoordhuis
    on May 31, 2017
    Member

    V8 flags come and go, we don't normally call them out in the release notes. I'll go ahead and close this.

  6. bnoordhuis
    closed this as completedon May 31, 2017
  7. edouard-lopez
    added 2 commits that reference this issue on Feb 24, 2018

    remove bad node option

    c13ddf4

    remove bad node option

    f0aee48
  8. hugolpz
    added a commit that references this issue on Feb 26, 2018

    remove bad node option

    3400d83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    cliIssues and PRs related to the Node.js command-line interface.v8 engineIssues and PRs related to the V8 dependency.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions