Skip to content

Document that you can only listen on an already closed socket #11685

Description

@gibfahn
  • Subsystem: doc

From #8419 (comment),

@addaleax raised a possible concern with #8294 which states in the docs that you can listen() on the same socket multiple times. It should probably say more clearly that you can only listen() on an already closed socket.

EDIT: PR raised: https://github.com/nodejs/node/pull/13149/files

Activity

  1. added
    docIssues and PRs related to Node.js documentation.
    good first issueIssues that are suitable for first-time contributors.
    netIssues and PRs related to the net subsystem.
    on Mar 4, 2017
  2. joyeecheung commented on Mar 5, 2017

    @joyeecheung
    Member

    Since listen() is overloaded it might help even more to point out what happens if you call listen() on different stuff multiple times..

    Also I think listen() doesn't actually raise an error when you try to listen on an unbound handle?

  3. eduardbme commented on Mar 5, 2017

    @eduardbme
    Contributor

    will do

  4. gibfahn commented on Mar 5, 2017

    @gibfahn
    MemberAuthor

    @eduardbcom if you're going to fix this (either in #8419 or a separate PR) then if you could add the Fixes: line to the commit and link to it from here that'd be great!

    Fixes: https://github.com/nodejs/node/issues/11685#issuecomment-284221748
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    docIssues and PRs related to Node.js documentation.good first issueIssues that are suitable for first-time contributors.netIssues and PRs related to the net subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions