Skip to content

Remove nonstandard WHATWG URL url.toString(true) #10750

Closed
Closed
Remove nonstandard WHATWG URL url.toString(true)#10750
adamlaska/node
#112
 (+9)
Labels
whatwg-urlIssues and PRs related to the WHATWG URL implementation.

Description

@domenic
domenic
opened on Jan 12, 2017

As with originFor and friends, it should ideally move to a separate export on the url module, instead of extending the standard object with unspecified behavior.

Activity

  1. mscdex
    added
    whatwg-urlIssues and PRs related to the WHATWG URL implementation.
    on Jan 12, 2017

  2. jasnell commented on Jan 12, 2017

    @jasnell
    jasnell
    on Jan 12, 2017
    Member

    definitely agree that this is not ideal. I would like to have a way of getting back the unicode/idna encoding of the URL without punycode tho so moving something into the url module makes sense.... although it is a bit annoying

  3. joyeecheung commented on Jan 22, 2017

    @joyeecheung
    joyeecheung
    on Jan 22, 2017
    Member

    Just noticed #10857 is gonna fix this (although TupleOrigin .toString() still has an unspecified argument).

  4. TimothyGu commented on Feb 2, 2017

    @TimothyGu
    TimothyGu
    on Feb 2, 2017
    Member

    Fixed in c5e9654...0d9ea4f

  5. TimothyGu
    closed this as completedon Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    whatwg-urlIssues and PRs related to the WHATWG URL implementation.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions