No Windows builds since 2020.05.28 #158

Activity

1. bzoz commented on Jun 1, 2020

   

   bzoz

   on Jun 1, 2020

   More actions

   Maybe it is because the build issues in nodejs/node#33579?
2. vsemozhetbyt commented on Jun 1, 2020

   

   vsemozhetbyt

   on Jun 1, 2020

   Author

   More actions

   FWIW, the recent nightly builds have Windows binaries:

   https://nodejs.org/download/nightly/v15.0.0-nightly202005296a1df3b5af/
   https://nodejs.org/download/nightly/v15.0.0-nightly20200530d79c330186/
   https://nodejs.org/download/nightly/v15.0.0-nightly202005312935f72ae1/
3. gengjiawen commented on Jun 1, 2020

   

   gengjiawen

   on Jun 1, 2020

   Member

   More actions

   Maybe it is because the build issues in nodejs/node#33579?

   Is it the node-v8 daily windows build using vs2017 ? @targos @ryzokuken
4. gengjiawen commented on Jun 1, 2020

   

   gengjiawen

   on Jun 1, 2020

   Last edited by gengjiawen

   Member

   More actions

   Looks like windows build is broken: https://github.com/nodejs/node-v8/runs/726470134.

   C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.25.28610\include\memory(1757,1): error C2027: use of undefined type 'v8::internal::OffThreadTransferHandleStorage' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_init.vcxproj]
   D:\a\node-v8\node-v8\deps\v8\src\execution\off-thread-isolate.h(20): message : see declaration of 'v8::internal::OffThreadTransferHandleStorage' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_init.vcxproj]
   C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.25.28610\include\memory(1756): message : while compiling class template member function 'void std::default_delete<v8::internal::OffThreadTransferHandleStorage>::operator ()(_Ty *) noexcept const' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_init.vcxproj]
             with
             [
                 _Ty=v8::internal::OffThreadTransferHandleStorage
             ]
   
5. gengjiawen commented on Jun 1, 2020

   

   gengjiawen

   on Jun 1, 2020

   Member

   More actions

   Looks like windows build is broken: nodejs/node-v8/runs/726470134.

   C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.25.28610\include\memory(1757,1): error C2027: use of undefined type 'v8::internal::OffThreadTransferHandleStorage' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_init.vcxproj]
   D:\a\node-v8\node-v8\deps\v8\src\execution\off-thread-isolate.h(20): message : see declaration of 'v8::internal::OffThreadTransferHandleStorage' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_init.vcxproj]
   C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.25.28610\include\memory(1756): message : while compiling class template member function 'void std::default_delete<v8::internal::OffThreadTransferHandleStorage>::operator ()(_Ty *) noexcept const' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_init.vcxproj]
             with
             [
                 _Ty=v8::internal::OffThreadTransferHandleStorage
             ]
   

   Not sure related to this:
   nodejs/node#33685
   v8/v8@e87972b#commitcomment-39582496.
6. gengjiawen commented on Jun 1, 2020

   

   gengjiawen

   on Jun 1, 2020

   Member

   More actions

   Possible fix: #159

   👍React with 👍1Reacted by Vse Mozhe Buty
7. gengjiawen commented on Jun 2, 2020

   

   gengjiawen

   on Jun 2, 2020

   Last edited by gengjiawen

   Member

   More actions

   Possible fix: #159

   Looks like build passed on github action.

   Upstream patch: https://chromium-review.googlesource.com/c/v8/v8/+/2226121.
8. gengjiawen commented on Jun 3, 2020

   

   gengjiawen

   on Jun 3, 2020

   Member

   More actions

   Looks like fixed: https://nodejs.org/download/v8-canary/v15.0.0-v8-canary20200603908772e6f4/

   ❤️React with ❤️2Reacted by Vse Mozhe Buty and Ujjwal Sharma
9. gengjiawen

   closed this as completedon Jun 3, 2020