Repository navigation
chore: license - #164
chore: license#164
Conversation
Signed-off-by: Daniel Cavalcante <2281265+dcavalcante@users.noreply.github.com>
Signed-off-by: Daniel Cavalcante <2281265+dcavalcante@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The license matches the stated source and is correctly linked from the README.
Review effort: Balanced
Findings: None
What changed in this PR
Adds an explicit root MIT license for the standalone Learn repository.
Changes:
- Adds the MIT license copied from
nodejs/nodejs.org. - Links the license from the README.
| File | Description |
|---|---|
README.md |
Documents and links the repository license. |
LICENSE |
Adds the MIT license text. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com> Signed-off-by: Daniel Cavalcante <dcavalcante@gmail.com>
araujogui
left a comment
There was a problem hiding this comment.
LGTM however we could add private and license fields on package.json too
Good point.. While adding Would it make sense to add |
|
License field seem good idea but private field should be another pr |
So.. I guess the name field is another PR too |
|
Private and name can be in the same pr |
Signed-off-by: Daniel Cavalcante <dcavalcante@gmail.com>
agreed, done! |
The Learn content was moved out of
nodejs/nodejs.orginto this standalone repository, butnodejs/learncurrently does not contain a root license file.nodejs/nodejs.orgis MIT-licensed, so this copies itsLICENSEverbatim.Having the license in the standalone repository makes the applicable terms explicit for contributors and downstream consumers of the Learn content. In my case, assembling an epub book version of it: dcavalcante/nodejs-docs-ebook