Skip to content

chore: license - #164

Merged
bmuenzenmeyer merged 4 commits into
nodejs:mainfrom
dcavalcante:meta/add-license
Oct 4, 2026
Merged

bmuenzenmeyer merged 4 commits into
nodejs:mainfrom
dcavalcante:meta/add-license

Conversation

@dcavalcante

Copy link
Copy Markdown
Contributor

The Learn content was moved out of nodejs/nodejs.org into this standalone repository, but nodejs/learn currently does not contain a root license file.

nodejs/nodejs.org is MIT-licensed, so this copies its LICENSE verbatim.

Having the license in the standalone repository makes the applicable terms explicit for contributors and downstream consumers of the Learn content. In my case, assembling an epub book version of it: dcavalcante/nodejs-docs-ebook

Signed-off-by: Daniel Cavalcante <2281265+dcavalcante@users.noreply.github.com>
Signed-off-by: Daniel Cavalcante <2281265+dcavalcante@users.noreply.github.com>
@dcavalcante
dcavalcante requested a review from a team as a code owner October 1, 2026 22:09
Copilot AI balanced review requested due to automatic review settings October 1, 2026 22:09
@vercel

vercel Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nodejs-learn Ready Ready Preview Oct 3, 2026 11:30am UTC

Request Review

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The license matches the stated source and is correctly linked from the README.

Review effort: Balanced
Findings: None

What changed in this PR

Adds an explicit root MIT license for the standalone Learn repository.

Changes:

  • Adds the MIT license copied from nodejs/nodejs.org.
  • Links the license from the README.
File Description
README.md Documents and links the repository license.
LICENSE Adds the MIT license text.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@avivkeller avivkeller changed the title Meta/add license chore: license Oct 2, 2026
Comment thread LICENSE Outdated
Co-authored-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
Signed-off-by: Daniel Cavalcante <dcavalcante@gmail.com>

@araujogui araujogui left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM however we could add private and license fields on package.json too

@dcavalcante

Copy link
Copy Markdown
Contributor Author

LGTM however we could add private and license fields on package.json too

Good point.. While adding private and license, I noticed package.json currently has no name prop, while package-lock.json had "name": "learn". Running npm install --package-lock-only from my checkout (my local folder is named nodejs-learn) caused npm to rewrite that lockfile name to "nodejs-learn"..

Would it make sense to add "name": "learn" to package.json in this PR as well, so the package metadata is explicit and the lockfile stays stable regardless of the checkout directory?

@AugustinMauroy

Copy link
Copy Markdown
Member

License field seem good idea but private field should be another pr

@dcavalcante

Copy link
Copy Markdown
Contributor Author

License field seem good idea but private field should be another pr

So.. I guess the name field is another PR too

@AugustinMauroy

Copy link
Copy Markdown
Member

Private and name can be in the same pr

Signed-off-by: Daniel Cavalcante <dcavalcante@gmail.com>
@dcavalcante

Copy link
Copy Markdown
Contributor Author

Private and name can be in the same pr

agreed, done!

@bmuenzenmeyer
bmuenzenmeyer added this pull request to the merge queue Oct 4, 2026
Merged via the queue into nodejs:main with commit 4171c91 Oct 4, 2026
5 checks passed

This branch was successfully deployed

1 active deployment
Preview — f344fd06 Deployed Oct 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants