Skip to content

Building v8/node/vee-eight-lkgr fails in Windows 7 x64 #471

Closed
Closed
Building v8/node/vee-eight-lkgr fails in Windows 7 x64#471

Description

@vsemozhetbyt
vsemozhetbyt
opened on Jan 29, 2017

  • Node.js Version: https://github.com/v8/node/tree/vee-eight-lkgr

  • OS: Windows 7 x64

  • Scope: build

  • Prerequisites: Python 2.7.13; Visual C++ Build Tools 2015 14.0.25420.1; Git for Windows 2.11.0.3-64-bit (Unix tools are included in the global PATH)

  • Command: .\vcbuild nosign in the cmd.exe (according to BUILDING.md nosign is still used there)

The last output fragment:

cmd

Text (click me): 
  j:\temp\node-vee-eight-lkgr\deps\v8\src/interface-descriptors.h(142): note: see declaration of 'std::unique_ptr<v8::internal::MachineType [],std::default_del
  ete<_Ty>>'
          with
          [
              _Ty=v8::internal::MachineType []
          ] (compiling source file ic\ia32\access-compiler-ia32.cc)
  Console.cpp
c1xx : fatal error C1083: Cannot open source file: '..\..\..\build\Release\obj\global_intermediate\src\inspector\protocol\Console.cpp': No such file or directo
ry [j:\temp\node-vee-eight-lkgr\deps\v8\src\v8_base_3.vcxproj]
  HeapProfiler.cpp
c1xx : fatal error C1083: Cannot open source file: '..\..\..\build\Release\obj\global_intermediate\src\inspector\protocol\HeapProfiler.cpp': No such file or di
rectory [j:\temp\node-vee-eight-lkgr\deps\v8\src\v8_base_3.vcxproj]
  Runtime.cpp
c1xx : fatal error C1083: Cannot open source file: '..\..\..\build\Release\obj\global_intermediate\src\inspector\protocol\Runtime.cpp': No such file or directo
ry [j:\temp\node-vee-eight-lkgr\deps\v8\src\v8_base_3.vcxproj]
  string-16.cc
j:\temp\node-vee-eight-lkgr\deps\v8\src/inspector/string-16.h(85): warning C4244: 'initializing': conversion from 'const unsigned short' to 'char', possible lo
ss of data (compiling source file inspector\string-16.cc) [j:\temp\node-vee-eight-lkgr\deps\v8\src\v8_base_3.vcxproj]
C:\Program Files (x86)\Windows Kits\8.1\Include\um\dbghelp.h(1544): warning C4091: 'typedef ': ignored on left of '' when no variable is declared (compiling so
urce file inspector\string-16.cc) [j:\temp\node-vee-eight-lkgr\deps\v8\src\v8_base_3.vcxproj]
C:\Program Files (x86)\Windows Kits\8.1\Include\um\dbghelp.h(3190): warning C4091: 'typedef ': ignored on left of '' when no variable is declared (compiling source file inspector\string-16.cc) [j:\temp\node-vee-eight-lkgr\deps\v8\src\v8_base_3.vcxproj]
j:\temp\node-vee-eight-lkgr\deps\v8\src/zone/accounting-allocator.h(80): warning C4251: 'v8::internal::AccountingAllocator::unused_segments_mutex_': class 'v8::base::Mutex' needs to have dll-interface to be used by clients of class 'v8::internal::AccountingAllocator' (compiling source file inspector\string-16.cc) [j:\temp\node-vee-eight-lkgr\deps\v8\src\v8_base_3.vcxproj]
  j:\temp\node-vee-eight-lkgr\deps\v8\src/globals.h(62): note: see declaration of 'v8::base::Mutex' (compiling source file inspector\string-16.cc)
j:\temp\node-vee-eight-lkgr\deps\v8\src/zone/accounting-allocator.h(86): warning C4251: 'v8::internal::AccountingAllocator::memory_pressure_level_': class 'v8::base::AtomicValue<v8::MemoryPressureLevel>' needs to have dll-interface to be used by clients of class 'v8::internal::AccountingAllocator' (compiling source file inspector\string-16.cc) [j:\temp\node-vee-eight-lkgr\deps\v8\src\v8_base_3.vcxproj]
  j:\temp\node-vee-eight-lkgr\deps\v8\src/zone/accounting-allocator.h(86): note: see declaration of 'v8::base::AtomicValue<v8::MemoryPressureLevel>' (compiling source file inspector\string-16.cc)
  v8-console.cc
  v8-console-message.cc
j:\temp\node-vee-eight-lkgr\deps\v8\src/inspector/v8-console-message.h(10): fatal error C1083: Cannot open include file: 'src/inspector/protocol/Console.h': No such file or directory (compiling source file inspector\v8-console-message.cc) [j:\temp\node-vee-eight-lkgr\deps\v8\src\v8_base_3.vcxproj]
  v8-debugger-agent-impl.cc
j:\temp\node-vee-eight-lkgr\deps\v8\src/inspector/injected-script-native.h(10): fatal error C1083: Cannot open include file: 'src/inspector/protocol/Protocol.h': No such file or directory (compiling source file inspector\v8-console.cc) [j:\temp\node-vee-eight-lkgr\deps\v8\src\v8_base_3.vcxproj]
  v8-function-call.cc
j:\temp\node-vee-eight-lkgr\deps\v8\src/inspector/string-16.h(85): warning C4244: 'initializing': conversion from 'const unsigned short' to 'char', possible loss of data (compiling source file inspector\v8-function-call.cc) [j:\temp\node-vee-eight-lkgr\deps\v8\src\v8_base_3.vcxproj]
j:\temp\node-vee-eight-lkgr\deps\v8\src/inspector/v8-debugger-agent-impl.h(12): fatal error C1083: Cannot open include file: 'src/inspector/protocol/Debugger.h': No such file or directory (compiling source file inspector\v8-debugger-agent-impl.cc) [j:\temp\node-vee-eight-lkgr\deps\v8\src\v8_base_3.vcxproj]
  v8-injected-script-host.cc
j:\temp\node-vee-eight-lkgr\deps\v8\include/v8-inspector.h(80): warning C4251: 'v8_inspector::V8ContextInfo::context': class 'v8::Local<v8::Context>' needs to have dll-interface to be used by clients of class 'v8_inspector::V8ContextInfo' (compiling source file inspector\v8-function-call.cc) [j:\temp\node-vee-eight-lkgr\deps\v8\src\v8_base_3.vcxproj]
  j:\temp\node-vee-eight-lkgr\deps\v8\include/v8.h(1070): note: see declaration of 'v8::Local<v8::Context>' (compiling source file inspector\v8-function-call.cc)
j:\temp\node-vee-eight-lkgr\deps\v8\src/inspector/v8-debugger.h(13): fatal error C1083: Cannot open include file: 'src/inspector/protocol/Forward.h': No such file or directory (compiling source file inspector\v8-function-call.cc) [j:\temp\node-vee-eight-lkgr\deps\v8\src\v8_base_3.vcxproj]
  v8-inspector-session-impl.cc
j:\temp\node-vee-eight-lkgr\deps\v8\src/inspector/injected-script-native.h(10): fatal error C1083: Cannot open include file: 'src/inspector/protocol/Protocol.h': No such file or directory (compiling source file inspector\v8-injected-script-host.cc) [j:\temp\node-vee-eight-lkgr\deps\v8\src\v8_base_3.vcxproj]
  v8-profiler-agent-impl.cc
j:\temp\node-vee-eight-lkgr\deps\v8\src/inspector/v8-inspector-session-impl.h(11): fatal error C1083: Cannot open include file: 'src/inspector/protocol/Forward.h': No such file or directory (compiling source file inspector\v8-inspector-session-impl.cc) [j:\temp\node-vee-eight-lkgr\deps\v8\src\v8_base_3.vcxproj]
  v8-runtime-agent-impl.cc
j:\temp\node-vee-eight-lkgr\deps\v8\src/inspector/v8-profiler-agent-impl.h(11): fatal error C1083: Cannot open include file: 'src/inspector/protocol/Forward.h': No such file or directory (compiling source file inspector\v8-profiler-agent-impl.cc) [j:\temp\node-vee-eight-lkgr\deps\v8\src\v8_base_3.vcxproj]
  v8-stack-trace-impl.cc
j:\temp\node-vee-eight-lkgr\deps\v8\src/inspector/v8-runtime-agent-impl.h(35): fatal error C1083: Cannot open include file: 'src/inspector/protocol/Forward.h': No such file or directory (compiling source file inspector\v8-runtime-agent-impl.cc) [j:\temp\node-vee-eight-lkgr\deps\v8\src\v8_base_3.vcxproj]
  wasm-translation.cc
j:\temp\node-vee-eight-lkgr\deps\v8\src/inspector/v8-stack-trace-impl.h(11): fatal error C1083: Cannot open include file: 'src/inspector/protocol/Forward.h': No such file or directory (compiling source file inspector\v8-stack-trace-impl.cc) [j:\temp\node-vee-eight-lkgr\deps\v8\src\v8_base_3.vcxproj]
  bytecode-peephole-table.cc
j:\temp\node-vee-eight-lkgr\deps\v8\src/inspector/string-16.h(85): warning C4244: 'initializing': conversion from 'const unsigned short' to 'char', possible loss of data (compiling source file inspector\wasm-translation.cc) [j:\temp\node-vee-eight-lkgr\deps\v8\src\v8_base_3.vcxproj]
inspector\wasm-translation.cc(10): fatal error C1083: Cannot open include file: 'src/inspector/protocol/Debugger.h': No such file or directory [j:\temp\node-vee-eight-lkgr\deps\v8\src\v8_base_3.vcxproj]

j:\temp\node-vee-eight-lkgr>

The content of the .\build\Release\obj\global_intermediate folder after the fail (no folders mentioned in the error output, just these files):

r1

The content of the .\Release\obj\global_intermediate\src\inspector\protocol\ folder after the fail:

r2

Could the v8/node/vee-eight-lkgr be built in my environment? Should I correct something? Should I provide some more information?

Activity

  1. vsemozhetbyt
    changed the title [-]Building v8/node/vee-eight-lkgr fails silently[/-] [+]Building v8/node/vee-eight-lkgr fails[/+] on Jan 29, 2017
  2. vsemozhetbyt
    changed the title [-]Building v8/node/vee-eight-lkgr fails[/-] [+]Building v8/node/vee-eight-lkgr fails in Windows 7 x64[/+] on Jan 29, 2017

  3. targos commented on Jan 29, 2017

    @targos
    targos
    on Jan 29, 2017
    Member

    Same issue as nodejs/node#10992 (comment). Whoever finds the fix will help us to land V8 5.6 on master ;)

  4. vsemozhetbyt commented on Jan 29, 2017

    @vsemozhetbyt
    vsemozhetbyt
    on Jan 29, 2017
    Author

    @targos
    FWIW, the content of .\deps\v8\src\v8_base_3.vcxproj which causes the first error.

    The first unfound file seems to be required on this line

    There is no such file in the ..\..\..\build\Release\obj\global_intermediate\src\inspector\protocol\, but there is such file in the ..\..\..\Release\obj\global_intermediate\src\inspector\protocol\. Could it be that $(OutDir) variable is set or used wrongly by that time? Sorry, I know nothing about build process...

  5. bnoordhuis commented on Feb 8, 2017

    @bnoordhuis
    bnoordhuis
    on Feb 8, 2017
    Member

    I'll take a look. My hunch is conflicting uses of PRODUCT_DIR vs. SHARED_INTERMEDIATE_DIR.

  6. bnoordhuis commented on Feb 8, 2017

    @bnoordhuis
    bnoordhuis
    on Feb 8, 2017
    Member

    @vsemozhetbyt Do the patches from nodejs/node#10992 (comment) work for you?

  7. vsemozhetbyt commented on Feb 8, 2017

    @vsemozhetbyt
    vsemozhetbyt
    on Feb 8, 2017
    Author

    @bnoordhuis Yes, deleting two lines mentioned in the first diff seems to fix the building. Thank you.

  8. vsemozhetbyt
    closed this as completedon Feb 8, 2017

  9. vsemozhetbyt commented on Feb 8, 2017

    @vsemozhetbyt
    vsemozhetbyt
    on Feb 8, 2017
    Author

    @bnoordhuis However, it seems this line in the BUILDING.md:

    > .\vcbuild test

    should be replaced by

    > .\vcbuild test nosign

    (Currently testing after building fails due to signing attempt failure).

    Or maybe the team could land the nodejs/node@92ed1ab and nodejs/node@7cd6a7d

  10. gibfahn commented on Feb 9, 2017

    @gibfahn
    gibfahn
    on Feb 9, 2017
    Member

    Or maybe the team could land the nodejs/node@92ed1ab and nodejs/node@7cd6a7d

    If vee-eight-lkgr is based on master, it probably just needs a rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions