Repository navigation
Drop the unused Nullable parameter of the conversion accessor - #92
Merged
Merged
Conversation
cast_dispatch_base took a Nullable parameter so that the accessor of substitution_dispatch could convert an empty proxy to an empty proxy without invoking the dispatch. substitution_dispatch has been gone since ngcpp#84, and both remaining users, implicit_conversion_dispatch and explicit_conversion_dispatch, pass false, so the branch it guarded was never instantiated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring. No functional change.