Repository navigation
Remove orphaned keys from package.nls.json (#22478) - #26159
Shriraj Jadhav (Shriraj1901) wants to merge 1 commit into
Conversation
Removes 8 unused localization keys that no longer have any corresponding reference in package.json or the extension source: - 2 TensorBoard command titles (feature moved to separate extension) - TensorBoard experiment description - 3 TensorBoard log directory strings - 2 walkthrough 'Select a Python Interpreter' strings (step was merged into the 'createEnvironment' walkthrough step) Verified via search across src/**/*.ts that none of these keys are referenced anywhere in the codebase.
|
🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Summary: The verification sandbox failed during staging, before the discovery command or tests could execute. Read-only inspection found no dedicated test covering removal of orphaned `package.nls.json` keys, and the PR adds no tests. Therefore, runtime verification could not be completed. Test runs: 1 not run
|
Bill Schnurr (bschnurr)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
|
@microsoft-github-policy-service agree |
16ab2b7 to
db91e3d
Compare
Bill Schnurr (bschnurr)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Heejae Chang (heejaechang)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Description
Removes 8 unused localization keys from
package.nls.jsonthat no longer have any corresponding reference inpackage.jsonor anywhere in the extension source code (src/).The orphaned keys break down into two groups:
How this was verified
Ran a script comparing every
%key%reference acrosspackage.jsonagainstpackage.nls.json, and separately searched the entiresrc/**/*.tsfor any remaining usage of each orphaned key. All 8 came back with zero references anywhere in the codebase.Fixes #22478