fix: preserve Markdown hard line breaks - #2559
Open
Maciej Zmitrukiewicz (MaciejZet) wants to merge 1 commit into
Open
Maciej Zmitrukiewicz (MaciejZet) wants to merge 1 commit into
Maciej Zmitrukiewicz (MaciejZet) wants to merge 1 commit into
Conversation
Normalization stripped every trailing space, so a CommonMark hard break became a soft break. HTML and DOCX line breaks are emitted as those two spaces.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MarkItDown._convertwas stripping every trailing space, so a CommonMark hard break (two or more spaces before a newline) became a soft break.<br>and DOCX<w:br/>are emitted by markdownify as those two spaces. Existing expectations for that output now keep the hard break.Test plan
tests/test_markdown_whitespace.py: hard breaks, CRLF, backslash breaks, tabs, blank-line collapsing, fenced code, real.mdinput, and HTML<br>pytest testsinpackages/markitdownon Python 3.12 with theallextra: 1024 passed, 14 skipped