Repository navigation
Publish signed release copies for payload commit d7d20d9 - #146
Merged
Merged
Conversation
Manodasan Wignarajah (manodasanW)
approved these changes
Oct 6, 2026
ranm-msft
reviewed
Oct 6, 2026
ranm-msft
left a comment
There was a problem hiding this comment.
Approving.
This diff is 4 changed files and ~1000 changed lines, but almost all of it is Authenticode signature blocks. Filtering comment lines out leaves exactly 8 semantic lines: the same $payloadRef bump repeated four times, in Workloads/winui/setup.ps1, windows-dev-config/setup-full.ps1, windows-dev-config/setup-standard.ps1 and windows-dev-config/uninstall.ps1.
I verified the new pin rather than taking it on trust:
d7d20d9077d2801acdd27c8387c481136f100317resolves toSigned dev config files (#142).windows-dev-config/bootstrap.ps1exists at that ref (37,801 bytes).- Comparing
main...d7d20d9reportsbehind_by: 11,ahead_by: 0- the ref is an ancestor ofmain, so the pin cannot dangle later.
All four call sites moved together, so there is no split-brain between the setup and uninstall paths. No asks.
ranm-msft
approved these changes
Oct 6, 2026
ranm-msft
left a comment
There was a problem hiding this comment.
Recording the disposition explicitly: approve. (My previous comment has the detail; the verification of the new $payloadRef is in there.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publish signed launcher copies that reference payload commit
d7d20d9, matching the source launcher update.