Ensure stable ordering in getInferTypeParameters result - #64621
Merged
Merged
Conversation
typescript-automation
Bot
added
Author: Team
For Milestone Bug
Copilot started reviewing on behalf of
Anders Hejlsberg (ahejlsberg)
October 3, 2026 16:35
View session
Anders Hejlsberg (ahejlsberg)
requested review from
Ryan Cavanaugh (RyanCavanaugh) and
Jake Bailey (jakebailey)
October 3, 2026 16:36
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The deterministic sort directly addresses the unordered symbol-table iteration, with focused regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Ensures deterministic declaration emit by stably ordering inferred type parameters before constructing type mappers.
Changes:
- Sorts inferred type parameters using
CompareTypes. - Adds a regression test and declaration/type/symbol baselines for #64589.
| File | Description |
|---|---|
tsc/internal/checker/checker.go |
Stabilizes inferred type-parameter ordering. |
tsc/testdata/tests/cases/compiler/stableTypeMapperOrdering.ts |
Adds the regression case. |
tsc/testdata/baselines/reference/compiler/stableTypeMapperOrdering.js |
Captures emit and declaration output. |
tsc/testdata/baselines/reference/compiler/stableTypeMapperOrdering.types |
Captures inferred types. |
tsc/testdata/baselines/reference/compiler/stableTypeMapperOrdering.symbols |
Captures resolved symbols. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Jake Bailey (jakebailey)
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64589.