Fix nullability intersections in CFA and relations by ahejlsberg · Pull Request #57724 · microsoft/TypeScript

Anders Hejlsberg (ahejlsberg) · 2024-03-11T17:02:14Z

Anders Hejlsberg (ahejlsberg) · 2024-03-11T17:05:12Z

TypeScript Bot (@typescript-bot) test top200
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this faster

TypeScript Bot (typescript-bot) · 2024-03-11T17:05:16Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top200`	✅ Started	✅ Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-03-11T17:29:05Z

Hey Anders Hejlsberg (@ahejlsberg), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

TypeScript Bot (typescript-bot) · 2024-03-11T17:31:36Z

Anders Hejlsberg (@ahejlsberg) Here are the results of running the user test suite comparing main and refs/pull/57724/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"
1 instance of "Unknown failure"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L13 in packages/browsers/test/src/tsconfig.json

TypeScript Bot (typescript-bot) · 2024-03-11T17:56:57Z

Anders Hejlsberg (@ahejlsberg)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,545k (± 0.01%)}	_{295,559k (± 0.01%)}	_~	_295,534k	_295,594k	_{p=0.423 n=6}
_{Parse Time}	_{2.66s (± 0.15%)}	_{2.67s (± 0.28%)}	_~	_2.66s	_2.68s	_{p=0.100 n=6}
_{Bind Time}	_{0.83s (± 0.62%)}	_{0.83s (± 0.00%)}	_~	_0.83s	_0.83s	_{p=0.174 n=6}
_{Check Time}	_{8.20s (± 0.43%)}	_{8.23s (± 0.21%)}	_~	_8.21s	_8.25s	_{p=0.134 n=6}
_{Emit Time}	_{7.13s (± 0.19%)}	_{7.13s (± 0.15%)}	_~	_7.11s	_7.14s	_{p=0.867 n=6}
_{Total Time}	_{18.81s (± 0.22%)}	_{18.85s (± 0.16%)}	_~	_18.82s	_18.89s	_{p=0.294 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,248k (± 1.01%)}	_{192,651k (± 0.92%)}	_~	_191,432k	_194,953k	_{p=0.471 n=6}
_{Parse Time}	_{1.36s (± 0.40%)}	_{1.36s (± 0.86%)}	_~	_1.34s	_1.37s	_{p=0.498 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.37s (± 0.28%)}	_{9.31s (± 0.29%)}	_{-0.06s (- 0.62%)}	_9.27s	_9.35s	_{p=0.012 n=6}
_{Emit Time}	_{2.61s (± 0.42%)}	_{2.60s (± 0.86%)}	_~	_2.58s	_2.64s	_{p=0.318 n=6}
_{Total Time}	_{14.05s (± 0.23%)}	_{13.99s (± 0.31%)}	_{-0.07s (- 0.47%)}	_13.91s	_14.04s	_{p=0.020 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,321k (± 0.00%)}	_{347,316k (± 0.01%)}	_~	_347,291k	_347,340k	_{p=0.936 n=6}
_{Parse Time}	_{2.48s (± 0.44%)}	_{2.48s (± 0.66%)}	_~	_2.45s	_2.49s	_{p=0.933 n=6}
_{Bind Time}	_{0.93s (± 0.44%)}	_{0.92s (± 0.56%)}	_{-0.01s (- 0.89%)}	_0.92s	_0.93s	_{p=0.022 n=6}
_{Check Time}	_{6.95s (± 0.20%)}	_{6.96s (± 0.34%)}	_~	_6.93s	_6.99s	_{p=0.570 n=6}
_{Emit Time}	_{4.06s (± 0.29%)}	_{4.06s (± 0.38%)}	_~	_4.05s	_4.09s	_{p=0.457 n=6}
_{Total Time}	_{14.42s (± 0.17%)}	_{14.43s (± 0.25%)}	_~	_14.39s	_14.49s	_{p=0.936 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,753k (± 0.00%)}	_{302,794k (± 0.01%)}	_{+41k (+ 0.01%)}	_302,765k	_302,842k	_{p=0.006 n=6}
_{Parse Time}	_{2.01s (± 0.58%)}	_{1.99s (± 1.48%)}	_~	_1.96s	_2.03s	_{p=0.366 n=6}
_{Bind Time}	_{1.00s (± 1.03%)}	_{1.01s (± 1.04%)}	_~	_0.99s	_1.02s	_{p=0.801 n=6}
_{Check Time}	_{6.34s (± 0.22%)}	_{6.34s (± 0.44%)}	_~	_6.31s	_6.39s	_{p=0.371 n=6}
_{Emit Time}	_{3.59s (± 0.27%)}	_{3.60s (± 0.29%)}	_~	_3.58s	_3.61s	_{p=0.547 n=6}
_{Total Time}	_{12.95s (± 0.12%)}	_{12.94s (± 0.22%)}	_~	_12.89s	_12.96s	_{p=0.681 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{511,231k (± 0.00%)}	_{511,239k (± 0.00%)}	_~	_511,224k	_511,255k	_{p=0.378 n=6}
_{Parse Time}	_{2.65s (± 0.62%)}	_{2.66s (± 0.51%)}	_~	_2.63s	_2.67s	_{p=1.000 n=6}
_{Bind Time}	_{0.98s (± 0.64%)}	_{0.99s (± 0.83%)}	_~	_0.98s	_1.00s	_{p=0.177 n=6}
_{Check Time}	_{17.29s (± 0.36%)}	_{17.31s (± 0.35%)}	_~	_17.22s	_17.37s	_{p=0.627 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.93s (± 0.35%)}	_{20.95s (± 0.33%)}	_~	_20.86s	_21.02s	_{p=0.419 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,789,710k (± 0.00%)}	_{1,789,729k (± 0.00%)}	_~	_1,789,686k	_1,789,781k	_{p=0.936 n=6}
_{Parse Time}	_{6.62s (± 0.48%)}	_{6.63s (± 0.51%)}	_~	_6.60s	_6.69s	_{p=0.808 n=6}
_{Bind Time}	_{2.40s (± 0.35%)}	_{2.38s (± 0.51%)}	_~	_2.36s	_2.39s	_{p=0.062 n=6}
_{Check Time}	_{58.81s (± 0.22%)}	_{59.07s (± 0.28%)}	_{+0.26s (+ 0.45%)}	_58.87s	_59.27s	_{p=0.031 n=6}
_{Emit Time}	_{0.17s (± 3.32%)}	_{0.17s (± 3.10%)}	_~	_0.16s	_0.17s	_{p=0.640 n=6}
_{Total Time}	_{67.99s (± 0.20%)}	_{68.25s (± 0.23%)}	_{+0.26s (+ 0.38%)}	_68.03s	_68.45s	_{p=0.031 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,394,063k (± 0.02%)}	_{2,394,116k (± 0.03%)}	_~	_2,393,155k	_2,394,884k	_{p=1.000 n=6}
_{Parse Time}	_{5.04s (± 0.88%)}	_{5.07s (± 0.46%)}	_~	_5.04s	_5.10s	_{p=0.230 n=6}
_{Bind Time}	_{1.89s (± 0.86%)}	_{1.89s (± 1.51%)}	_~	_1.85s	_1.92s	_{p=0.745 n=6}
_{Check Time}	_{33.66s (± 0.51%)}	_{33.71s (± 0.31%)}	_~	_33.58s	_33.83s	_{p=0.872 n=6}
_{Emit Time}	_{2.69s (± 1.82%)}	_{2.65s (± 0.81%)}	_~	_2.63s	_2.69s	_{p=0.128 n=6}
_{Total Time}	_{43.29s (± 0.52%)}	_{43.33s (± 0.26%)}	_~	_43.21s	_43.48s	_{p=1.000 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{414,469k (± 0.01%)}	_{414,563k (± 0.01%)}	_{+94k (+ 0.02%)}	_414,478k	_414,665k	_{p=0.031 n=6}
_{Parse Time}	_{2.80s (± 0.71%)}	_{2.79s (± 1.00%)}	_~	_2.76s	_2.83s	_{p=0.627 n=6}
_{Bind Time}	_{1.07s (± 0.48%)}	_{1.07s (± 0.51%)}	_~	_1.06s	_1.07s	_{p=0.640 n=6}
_{Check Time}	_{15.21s (± 0.39%)}	_{15.23s (± 0.40%)}	_~	_15.16s	_15.32s	_{p=0.627 n=6}
_{Emit Time}	_{1.10s (± 1.56%)}	_{1.11s (± 0.76%)}	_~	_1.09s	_1.11s	_{p=0.933 n=6}
_{Total Time}	_{20.18s (± 0.28%)}	_{20.19s (± 0.23%)}	_~	_20.16s	_20.26s	_{p=0.572 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,866,869k (± 0.00%)}	_{2,866,894k (± 0.00%)}	_~	_2,866,799k	_2,866,939k	_{p=0.521 n=6}
_{Parse Time}	_{10.76s (± 0.36%)}	_{10.78s (± 0.35%)}	_~	_10.73s	_10.83s	_{p=0.469 n=6}
_{Bind Time}	_{3.44s (± 0.22%)}	_{3.44s (± 0.30%)}	_~	_3.43s	_3.46s	_{p=0.931 n=6}
_{Check Time}	_{60.97s (± 0.41%)}	_{60.97s (± 0.19%)}	_~	_60.80s	_61.14s	_{p=0.936 n=6}
_{Emit Time}	_{16.26s (± 0.60%)}	_{16.27s (± 0.44%)}	_~	_16.19s	_16.39s	_{p=0.574 n=6}
_{Total Time}	_{91.43s (± 0.26%)}	_{91.46s (± 0.11%)}	_~	_91.26s	_91.56s	_{p=0.873 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{399,637k (± 0.00%)}	_{399,613k (± 0.02%)}	_~	_399,504k	_399,679k	_{p=0.521 n=6}
_{Parse Time}	_{3.23s (± 0.37%)}	_{3.22s (± 0.50%)}	_~	_3.21s	_3.25s	_{p=0.165 n=6}
_{Bind Time}	_{1.42s (± 1.07%)}	_{1.41s (± 1.83%)}	_~	_1.37s	_1.43s	_{p=0.742 n=6}
_{Check Time}	_{14.05s (± 0.35%)}	_{14.05s (± 0.28%)}	_~	_13.99s	_14.10s	_{p=0.808 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.70s (± 0.19%)}	_{18.68s (± 0.33%)}	_~	_18.60s	_18.78s	_{p=0.377 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,142k (± 0.01%)}	_{513,151k (± 0.01%)}	_~	_513,105k	_513,224k	_{p=0.936 n=6}
_{Parse Time}	_{3.28s (± 0.23%)}	_{3.28s (± 0.31%)}	_~	_3.26s	_3.29s	_{p=0.931 n=6}
_{Bind Time}	_{1.54s (± 0.49%)}	_{1.54s (± 0.41%)}	_~	_1.53s	_1.55s	_{p=0.718 n=6}
_{Check Time}	_{2.85s (± 0.52%)}	_{2.86s (± 0.48%)}	_~	_2.84s	_2.88s	_{p=0.290 n=6}
_{Emit Time}	_{0.08s (± 4.99%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=0.405 n=6}
_{Total Time}	_{7.75s (± 0.25%)}	_{7.76s (± 0.39%)}	_~	_7.72s	_7.81s	_{p=0.747 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2024-03-11T18:17:19Z

Anders Hejlsberg (@ahejlsberg) Here are the results of running the top-repos suite comparing main and refs/pull/57724/merge:

Everything looks good!

Ryan Cavanaugh (RyanCavanaugh) · 2024-03-11T18:29:01Z

+            hasNullableOrEmpty ||= !!(t.flags & TypeFlags.Nullable) || isEmptyAnonymousObjectType(t);
+        }
+        return hasInstantiable && hasNullableOrEmpty;


Potential to bail early from this loop

Suggested change

hasNullableOrEmpty ||= !!(t.flags & TypeFlags.Nullable) || isEmptyAnonymousObjectType(t);

}

return hasInstantiable && hasNullableOrEmpty;

hasNullableOrEmpty ||= !!(t.flags & TypeFlags.Nullable) || isEmptyAnonymousObjectType(t);

if (hasInstantiable && hasNullableOrEmpty) return true;

}

return false;

Sure, why not.

Anders Hejlsberg (ahejlsberg) added 4 commits March 9, 2024 16:28

Fix getAdjustedTypeWithFacts

4c07a31

Improve normalization of intersections

f462a18

Merge branch 'main' into fix57693

595cc38

Add tests

09a5bd5

TypeScript Bot (typescript-bot) assigned Anders Hejlsberg (ahejlsberg) Mar 11, 2024

TypeScript Bot (typescript-bot) added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Mar 11, 2024

Fix formatting

823c84f

Anders Hejlsberg (ahejlsberg) requested a review from Ryan Cavanaugh (RyanCavanaugh) March 11, 2024 17:06

Mateusz Burzyński (Andarist) mentioned this pull request Mar 11, 2024

Fix accidental null/undefined reduction when narrowing by null/undefined equality #57692

Closed

Ryan Cavanaugh (RyanCavanaugh) reviewed Mar 11, 2024

View reviewed changes

Ryan Cavanaugh (RyanCavanaugh) approved these changes Mar 11, 2024

View reviewed changes

Address CR feedback

1a5bb0f

Anders Hejlsberg (ahejlsberg) merged commit ef6a4ab into main Mar 11, 2024

Anders Hejlsberg (ahejlsberg) deleted the fix57693 branch March 11, 2024 21:00

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025

Navigation Menu

Repository navigation

Fix nullability intersections in CFA and relations - #57724

Fix nullability intersections in CFA and relations#57724
Anders Hejlsberg (ahejlsberg) merged 6 commits into
mainfrom
fix57693

Anders Hejlsberg (ahejlsberg) commented Mar 11, 2024

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Mar 11, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 11, 2024 •

edited

Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 11, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 11, 2024

puppeteer

packages/browsers/test/src/tsconfig.json

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 11, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 11, 2024

Uh oh!

Ryan Cavanaugh (RyanCavanaugh) Mar 11, 2024

Uh oh!

Anders Hejlsberg (ahejlsberg) Mar 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Anders Hejlsberg (ahejlsberg) commented Mar 11, 2024

Uh oh!

Anders Hejlsberg (ahejlsberg) commented Mar 11, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 11, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 11, 2024

puppeteer

packages/browsers/test/src/tsconfig.json

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 11, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 11, 2024

Uh oh!

Ryan Cavanaugh (RyanCavanaugh) Mar 11, 2024

Choose a reason for hiding this comment

Uh oh!

Anders Hejlsberg (ahejlsberg) Mar 11, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TypeScript Bot (typescript-bot) commented Mar 11, 2024 •

edited

Loading