Conversation
|
@GreedyC is attempting to deploy a commit to the MarkedJS Team on Vercel. A member of the Team first needs to authorize it. |
UziTech
requested changes
Sep 30, 2026
Member
There was a problem hiding this comment.
These tests should be moved to test/specs/new
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked version: 18.0.14 (current
master)Markdown flavor: CommonMark and GitHub Flavored Markdown
Description
Related to the list/tab indentation discussion in #4050. This addresses the continuation-line tab-stop calculation only, not the separate preservation of leading tabs inside fenced code.
Expectation
In a list continuation line, a tab advances to the next four-column tab stop. For example, two spaces followed by a tab occupy four columns, not six:
After removing the two-column list indentation,
barremains a paragraph rather than an indented code block.Result before this change
The leading whitespace replacement unconditionally added four spaces per tab. The example above therefore became an indented code block:
Change
Reuse
expandTabsfor the leading whitespace of non-pedantic continuation lines, starting at column zero. Interior tabs and the pedantic branch remain untouched. The existing first-line path already uses this helper with the bullet-column offset.Four new assertions failed on the unmodified implementation before the fix. The completed regression suite covers both parser flavors, unordered and one-/two-digit ordered markers, genuine indented code, interior tabs, tab-only blank lines, and nested lists. The reference CommonMark parser also confirms the paragraph-versus-code distinction for the reproducer.
Verification
npm testpassed on macOS with Node 20.20.2, Node 22.23.3, and Node 24.16.0: 1,863 spec tests and 207 unit tests per run, plus UMD/CJS, type/export checks, lint, and documentation build.05af44198272295a8e6255de053aeffc530684a1. npm scripts use Bash so Windows Node 20 expands the existingtest/unit/*.test.jsglob. A separate unchanged-baseline job confirms that the default Windows shell fails to expand that glob; no upstream package scripts were changed for this unrelated limitation.AI assistance: Codex was used for implementation and verification, and GitHub Copilot CLI for an additional local review.
Contributor
Committer