fix: support gemini-3.8-live and warn on api mismatches - #7587
Merged
Merged
Conversation
The model is available through both APIs. Reject only models known to the other API and absent from the selected API's list. Addresses AGT-3631. Diagnosis and proposed shared-model handling by Akiniesta: https://community.livekit.io/t/gemini-3-8-live-rejected-with-vertexai-true-in-livekit-plugins-google-although-vertex-ai-serves-it-eu-multi-region/2179
The Gemini API rejects thinking_level for gemini-3.8-live with error 1007. Fail at construction and point callers to the extended-thinking model. Apply the check to bare and models/ names on the Gemini API. Addresses AGT-3631.
davidzhao
approved these changes
Oct 2, 2026
Model availability can change before the plugin's known model lists are updated. Log a warning and let the provider decide whether the selected model is available. Continue to reject unsupported thinking_level settings. Addresses AGT-3631. Suggested by David Zhao: #7587 (comment) Co-authored-by: David Zhao <david@davidzhao.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gemini-3.8-liveworks on Vertex AI. Recognize shared models and warn about API mismatches so availability changes do not block callers, as davidzhao suggested. On the Gemini API, rejectthinking_levelforgemini-3.8-liveand recommendgemini-3.8-live-extended-thinking.Akiniesta's report supplied the diagnosis and proposed shared-model handling; this keeps the existing lists.
Addresses AGT-3631 (Linear).
Initial prompt and agent context
Model: GPT-6 Astra