Skip to content

Require passing checks on main and before publishing #126

Description

@CatarinaGamboa

Why: checks only protect main if a PR can't merge while they fail, and a release shouldn't publish a build that fails its tests.

What:

  • Branch protection (or a ruleset) on main that requires the test.yml jobs to pass.
  • Make publish.yml run the tests first. For example, turn test.yml into a reusable workflow (workflow_call) and add needs: to the publish job.

References:

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testingTesting related

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions