Repository navigation
Add SMT Unknown Error - #330
Merged
Merged
Conversation
This was referenced Oct 5, 2026
rcosta358
added this pull request to stack #332
October 5, 2026 14:10
CatarinaGamboa
approved these changes
Oct 6, 2026
CatarinaGamboa
left a comment
CatarinaGamboa
left a comment
Collaborator
There was a problem hiding this comment.
So we treat the unknowns as errors, right? I think thats okay since we are in Liquid Types that should be decidable so in a way this is also a way to say if what we are trying to reason about something undecidable. The solver.getReasonUnknown() is very cool
Collaborator
Author
|
Yes. I previously thought that it was impossible for the SMT solver to return unknown but it does when it tries to compare two values from different sorts (e.g., int and float). |
rcosta358
force-pushed
the
codex/smt-unknown-error
branch
from
October 6, 2026 15:18
08694c8 to
310bac3
Compare
rcosta358
added a commit
that referenced
this pull request
Oct 6, 2026
## Description Highlight the predicate in “Refinement declared here” diagnostics by reading its annotation position directly, removing the dependency on parsing order. ### Example #### Before <img width="810" height="270" alt="image" src="https://github.com/user-attachments/assets/c112084f-70b5-4640-a205-2bd743932df5" /> #### After <img width="625" height="273" alt="image" src="https://github.com/user-attachments/assets/aa1323a9-5742-4077-a6c3-b28c79f39481" /> Validation: 206 tests passed, including declaration-position regression tests. ## Related Issues Stacked on #330. Merge it first, then retarget to `main`. 🤖 Generated with [Codex](https://openai.com/codex/) --------- Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new
SMTUnknownErrorinstead of accepting refinements when Z3 returnsUNKNOWN.Includes a reason hint and the refinement declaration location.
Documentation update in #6.
Example
Related Issue
#303. It unexpectedly passes the verification because LJ reported unknown results as success.
Type of change
Checklist
liquidjava-example/src/main/java/testSuite/(Correct*/Error*)mvn testpasses locally