Repository navigation
Fix collisions between same-named fields - #327
Merged
Merged
Conversation
This was
linked to
issues
Oct 3, 2026
CatarinaGamboa
approved these changes
Oct 6, 2026
| } | ||
|
|
||
| public static String qualifyFieldName(CtFieldReference<?> field) { | ||
| return "this#" + field.getDeclaringType().getQualifiedName() + "." + field.getSimpleName(); |
Collaborator
There was a problem hiding this comment.
i wonder if we can also remove the # in the middle here and use the . so its more like java and less our workaround.
Collaborator
Author
There was a problem hiding this comment.
I had thought about that but that requires changing the grammar and will cause conflicts but we can give it a shot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #318 and #315.
Qualifies field names by declaring class, adds a combined nested-field regression, and fixes negative literal initializers.
Tests:
TestExamples(201 passed).This PR was generated by Codex.