Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DeepSeek no longer always exposes a model selector.
deepseek ask "hello" --newstill tried to select the defaultinstantmodel, so it failed withCould not switch to instant modelbefore sending the prompt.Only run model selection when
--modelwas explicitly supplied. A default invocation now uses DeepSeek's current model and proceeds to send. Explicit model requests still fail if DeepSeek cannot confirm the requested selection. The adapter documentation now describes this behavior and removes an example that combined incompatible model and search options.Related issue: #2484.
Type of Change
Checklist
Documentation (if adding/modifying an adapter)
docs/adapters/(if new adapter)docs/adapters/index.mdtable (if new adapter)docs/.vitepress/config.mts(if new adapter)README.md/README.zh-CN.mdwhen command discoverability changedCliErrorsubclasses instead of rawErrorVerification
npm exec vitest run -- --project adapter clis/deepseek/ask.test.js clis/deepseek/utils.test.js— 41 tests passednpm run typecheck— passedgit diff --check origin/main...HEAD— passedThe regression test covers
ask --newwhen the model selector is absent and verifies that sending continues. A separate test keeps the explicit--model instantfailure behavior.