Conversation
Adds webui/i18n/fa.json with a full translation of all 418 required UI strings, matching the same coverage tier as the other secondary locales (az, ca, de, es, fr, id, it, ko, pt, ru, tr, vi). Also adds fa-IR to the video script generation language options, and adds fa to the test suite's SECONDARY_LOCALES so coverage, format-placeholder, and markdown-URL checks run against it going forward. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Adds README-fa.md as a full Persian translation of README-en.md, following the existing en/ja localization pattern: all links, image sources, code blocks, and the in-page subtitle-generation anchor are preserved/adapted to match. Updates the language switcher line in README.md, README-en.md, and README-ja.md to link to it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Owner
|
Thanks for the substantial work on Persian support, including the locale tests and README translation. I appreciate the clear test notes. Before merging, I'd like to check the WebUI with Persian selected, particularly right-to-left text, alignment, and any clipping in the main form and settings dialog. The full README translation also needs a wording and consistency pass. I'll review those locally and follow up with any concrete issues; no need to make speculative changes in the meantime. Thanks again for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
webui/i18n/fa.jsonwith a full Persian translation of all 418 required UI strings, matching the same coverage tier as the other secondary locales (az, ca, de, es, fr, id, it, ko, pt, ru, tr, vi)fa-IRto the video script generation language options inwebui/Main.py, so users can also generate video scripts in PersianfatoSECONDARY_LOCALESintest/services/test_webui_i18n.pyso coverage, format-placeholder, and markdown-URL checks run against it going forwardREADME-fa.md, a full Persian translation ofREADME-en.md, following the existing en/ja localization pattern (links, image sources, code blocks, and the in-page anchor preserved/adapted to match), and updates the language switcher inREADME.md,README-en.md, andREADME-ja.mdto link to itTest plan
pytest test/services/test_webui_i18n.py -v— all 16 tests / ~11k subtests pass, including coverage, duplicate-key, format-placeholder, and markdown-URL preservation checks against the new localeutils.load_locales/utils.resolve_ui_languagethat thefalocale is discovered and resolves correctly fromfa/fa-IRbrowser localesREADME-fa.mdmatchesREADME-en.mdexactly (only expected differences: the self-referencing switcher link, and the in-page anchor updated to match the translated heading)🤖 Generated with Claude Code