Skip to content

Add Persian (fa) language support - #1405

Open
citoreh wants to merge 2 commits into
harry0703:mainfrom
citoreh:add-persian-language
Open

citoreh wants to merge 2 commits into
harry0703:mainfrom
citoreh:add-persian-language

Conversation

@citoreh

@citoreh citoreh commented Sep 25, 2026 •

Copy link
Copy Markdown

Summary

  • Adds webui/i18n/fa.json with a full Persian translation of all 418 required UI strings, matching the same coverage tier as the other secondary locales (az, ca, de, es, fr, id, it, ko, pt, ru, tr, vi)
  • Adds fa-IR to the video script generation language options in webui/Main.py, so users can also generate video scripts in Persian
  • Adds fa to SECONDARY_LOCALES in test/services/test_webui_i18n.py so coverage, format-placeholder, and markdown-URL checks run against it going forward
  • Adds README-fa.md, a full Persian translation of README-en.md, following the existing en/ja localization pattern (links, image sources, code blocks, and the in-page anchor preserved/adapted to match), and updates the language switcher in README.md, README-en.md, and README-ja.md to link to it

Test plan

  • pytest test/services/test_webui_i18n.py -v — all 16 tests / ~11k subtests pass, including coverage, duplicate-key, format-placeholder, and markdown-URL preservation checks against the new locale
  • Verified via utils.load_locales / utils.resolve_ui_language that the fa locale is discovered and resolves correctly from fa / fa-IR browser locales
  • Verified every link/image URL in README-fa.md matches README-en.md exactly (only expected differences: the self-referencing switcher link, and the in-page anchor updated to match the translated heading)
  • Visual/manual check of the WebUI with Persian selected (not done — no browser access in this environment; Persian is RTL and this app currently has no RTL layout support, same as all other non-Latin-script secondary locales added so far)

🤖 Generated with Claude Code

citoreh and others added 2 commits September 25, 2026 23:23
Adds webui/i18n/fa.json with a full translation of all 418 required
UI strings, matching the same coverage tier as the other secondary
locales (az, ca, de, es, fr, id, it, ko, pt, ru, tr, vi). Also adds
fa-IR to the video script generation language options, and adds fa
to the test suite's SECONDARY_LOCALES so coverage, format-placeholder,
and markdown-URL checks run against it going forward.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Adds README-fa.md as a full Persian translation of README-en.md,
following the existing en/ja localization pattern: all links, image
sources, code blocks, and the in-page subtitle-generation anchor are
preserved/adapted to match. Updates the language switcher line in
README.md, README-en.md, and README-ja.md to link to it.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@citoreh citoreh changed the title Add Persian (fa) language support to WebUI Add Persian (fa) language support Sep 25, 2026
@harry0703

Copy link
Copy Markdown
Owner

Thanks for the substantial work on Persian support, including the locale tests and README translation. I appreciate the clear test notes.

Before merging, I'd like to check the WebUI with Persian selected, particularly right-to-left text, alignment, and any clipping in the main form and settings dialog. The full README translation also needs a wording and consistency pass. I'll review those locally and follow up with any concrete issues; no need to make speculative changes in the meantime.

Thanks again for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants