Repository navigation
Diff fails on empty repository. #41
Description
Activity
Actually,
diff()works just fine. If you add some files into the index, you have to appendstaged(orcached) parameter to make diff to show the changes.>>> r.index.diff(None, staged=True) [<git.diff.Diff object at 0x2a86c80>]
But
is_dirty()behaves inconsistently. It should indeed returnFalse. My patch (1253036) fixes it. But I'm unable to run your nose tests and therefore I cannot update them. Hope this helps:#!/usr/bin/python import git import os os.system("rm -rf repo/") r = git.Repo.init("repo") os.system("echo foo > repo/foo") os.system("echo bar > repo/bar") assert not r.is_dirty() r.index.add(["foo"]) assert r.is_dirty() r.index.commit("foo messsage") assert not r.is_dirty() r.index.add(["bar"]) assert r.is_dirty()
Ah, I must have missed out on the
stagedkeyword in the docs. Thanks.Even though plenty of work has been done on this already, there is no test-case yet to truly verify this works. It should be done when working on 0.3.5.
A lot of time has passed, and plenty of changes were applied to
is_dirty(). Additionally, there are plenty of tests checking all aspects of it.
Therefore I believe this issue can be closed for now.
If you have an empty repository (
git initin an empty folder), then add files through GitPython, the repository isn't registered as "dirty" and diffs come back empty. For example:The index.entries property shows the newly added file, but there doesn't seem to be a way to turn it into "this file has been added, but not committed".