Skip to content

fix: return project item id usable for updates - #2169

Merged
SamMorrowDrums merged 2 commits into
github:mainfrom
njoppi2:fix/projects-write-item-id
May 31, 2026
Merged

SamMorrowDrums merged 2 commits into
github:mainfrom
njoppi2:fix/projects-write-item-id

Conversation

@njoppi2

@njoppi2 njoppi2 commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • include fullDatabaseId in the GraphQL response for projects_write / add_project_item
  • return a numeric item_id that can be passed directly to update_project_item and delete_project_item
  • keep the existing node id in the response for backwards compatibility

Closes #2153.

Validation

  • ran go test ./pkg/github -run "Test_ProjectsWrite_AddProjectItem|Test_ProjectsWrite_UpdateProjectItem" in a Go 1.24 Docker container
  • formatted touched files with gofmt in the same container

@njoppi2
njoppi2 requested a review from a team as a code owner March 7, 2026 05:37
@SamMorrowDrums
SamMorrowDrums force-pushed the fix/projects-write-item-id branch from af3968f to 5c0c341 Compare May 31, 2026 08:50

@SamMorrowDrums SamMorrowDrums left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean fix for #2153 — adds fullDatabaseId to the mutation and returns both full_database_id (string) and item_id (int64) so the result can be passed straight into update_project_item / delete_project_item. Existing node id preserved for backwards compat. Rebased onto main, tests pass, lint clean. Thanks!

@SamMorrowDrums
SamMorrowDrums merged commit 9266752 into github:main May 31, 2026
13 checks passed
social4hyq pushed a commit to social4hyq/homebrew-core that referenced this pull request Sep 20, 2026
github-mcp-server 1.2.0

Created-by: HarmonybrewBot
Commit-by: HarmonybrewBot
Merged-by: HarmonybrewBot
Description: Created by `brew bump`

---

Created with `brew bump-formula-pr`.<details>
  <summary>release notes</summary>
  <pre>## What's Changed
* MCP Apps: align with the 2026-01-26 stable spec by @mattdholloway in github/github-mcp-server#2573
* feat: add create_project and create_iteration_field methods to projects_write by @SamMorrowDrums in github/github-mcp-server#2232
* fix: restore thread id in get_review_comments response by @omid-ant in github/github-mcp-server#2245
* docs: add installation guides for Zed and OpenCode by @jluocsa in github/github-mcp-server#2535
* docs: improve Claude installation guide with Windows PowerShell support by @vincent067 in github/github-mcp-server#2312
* Fix remote-server docs inconsistency regarding toolset at base url by @korobitsin in github/github-mcp-server#2217
* fix: return project item id usable for updates by @njoppi2 in github/github-mcp-server#2169
* fix: add MCP initialize handshake to mcpcurl by @ra-n-dom in github/github-mcp-server#2009
* fix: support team pull request reviewers by @he-yufeng in github/github-mcp-server#2514
* Skip MCP App form when issue/PR write carries non-form params by @mattdholloway in github/github-mcp-server#2589
* feat: add include_patch parameter to get_commit tool by @voki-gandzhelashvili-t in github/github-mcp-server#1924
* MCP Apps: Open created issue/PR link via host open-link capability by @mattdholloway in github/github-mcp-server#2593
* fix: Empty assignees array should clear assignees by @RossTarrant in github/github-mcp-server#2600
* Add confidence parameter to issue mutation MCP tools by @alondahari in github/github-mcp-server#2605

## New Contributors
* @omid-ant made their first contribution in github/github-mcp-server#2245
* @vincent067 made their first contribution in github/github-mcp-server#2312
* @korobitsin made their first contribution in github/github-mcp-server#2217
* @njoppi2 made their first contribution in github/github-mcp-server#2169
* @ra-n-dom made their first contribution in github/github-mcp-server#2009
* @he-yufeng made their first contribution in github/github-mcp-server#2514
* @voki-gandzhelashvili-t made their first contribution in github/github-mcp-server#1924

**Full Changelog**: https://github.com/github/github-mcp-server/compare/v1.1.2...v1.2.0</pre>
  <p>View the full release notes at <a href="https://github.com/github/github-mcp-server/releases/tag/v1.2.0">https://github.com/github/github-mcp-server/releases/tag/v1.2.0</a>.</p>
</details>
<hr>

See merge request: Harmonybrew/homebrew-core!11013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

projects_write: item_id parameter typed as float64 instead of string

3 participants