Reordering a stack can cause PRs to be incorrectly marked as merged

[adjerbetian]

Problem

After reordering a published stack, I ran:

gh stack modify
gh stack push
gh stack submit

gh stack push updated the branch ancestry without updating the existing PR bases. Some PRs then targeted descendant branches that already contained their commits.

GitHub saw empty diffs and automatically marked those PRs as merged, although their commits were never merged into main. The PRs could not be reopened and had to be recreated with new branch names.

Version

gh stack version 0.0.8

Expected behavior

I expected gh stack push either

• to update the remote stack to match the reordered local stack,
• or to fail and tell me to use gh stack submit for this operation.

[amos-ddir]

I ran into essentially the same thing on 0.1.0