Skip to content

ref(rust-tracing): Drop send_default_pii support #7835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sentrivana merged 1 commit into from
Oct 5, 2026
Merged

ref(rust-tracing): Drop send_default_pii support #7835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions sentry_sdk/integrations/rust_tracing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@

import sentry_sdk
from sentry_sdk.integrations import Integration
from sentry_sdk.scope import should_send_default_pii
from sentry_sdk.utils import SENSITIVE_DATA_SUBSTITUTE

if TYPE_CHECKING:
Expand Down Expand Up @@ -161,14 +160,9 @@ def _include_tracing_fields(self) -> bool:
"""
By default, the values of tracing fields are not included in case they
contain PII. A user may override that by passing `True` for the
`include_tracing_fields` keyword argument of this integration or by
setting `send_default_pii` to `True` in their Sentry client options.
`include_tracing_fields` keyword argument of this integration.
"""
return (
should_send_default_pii()
if self.include_tracing_fields is None
else self.include_tracing_fields
)
return bool(self.include_tracing_fields)

def on_event(self, event: str, sentry_span: "Span") -> None:
deserialized_event = json.loads(event)
Expand Down
17 changes: 5 additions & 12 deletions tests/integrations/rust_tracing/test_rust_tracing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,21 +463,15 @@ def span_filter(metadata: Dict[str, object]) -> bool:


@pytest.mark.parametrize(
"send_default_pii, include_tracing_fields, tracing_fields_expected",
"include_tracing_fields, tracing_fields_expected",
[
(True, True, True),
(True, False, False),
(True, None, True),
(False, True, True),
(False, False, False),
(False, None, False),
(True, True),
(False, False),
(None, False),
],
)
def test_include_tracing_fields(
sentry_init,
send_default_pii,
include_tracing_fields,
tracing_fields_expected,
sentry_init, include_tracing_fields, tracing_fields_expected
):
rust_tracing = FakeRustTracing()
integration = RustTracingIntegration(
Expand All @@ -489,7 +483,6 @@ def test_include_tracing_fields(
sentry_init(
integrations=[integration],
traces_sample_rate=1.0,
send_default_pii=send_default_pii,
)
with sentry_sdk.start_span(name="custom parent"):
rust_tracing.new_span(RustTracingLevel.Info, 3)
Expand Down
Loading