Conversation
Lms24
added this pull request to stack #24904
October 2, 2026 09:44
Contributor
size-limit report 📦
|
Lms24
force-pushed
the
lms/fix-effect-tracer-clock-drift
branch
3 times, most recently
from
October 2, 2026 10:05
db2102a to
1d4abf9
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1d4abf9. Configure here.
Lms24
force-pushed
the
lms/fix-effect-tracer-clock-drift
branch
from
October 2, 2026 10:18
1d4abf9 to
29752e0
Compare
Lms24
marked this pull request as ready for review
October 2, 2026 11:53
Lms24
requested review from
JPeer264,
chargome and
nicohrubec
and removed request for
a team
October 2, 2026 11:53
JPeer264
approved these changes
Oct 2, 2026
Effect timestamps come from its own clock, a fixed origin plus a monotonic clock, which does not correct for clock drift (e.g. after the device slept). Sentry now does, so Effect spans could end up offset from the Sentry spans around them. Start Effect spans on the Sentry clock and convert end and event times by their offset from the span start. This keeps Effect durations and explicitly passed end times. If tracer timing is disabled, Effect passes 0 and we use the Sentry clock instead of producing 1970 timestamps. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Lms24
force-pushed
the
lms/fix-effect-tracer-clock-drift
branch
from
October 2, 2026 14:13
29752e0 to
fa51d1f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effect spans used Effect's own clock (a fixed origin plus a monotonic clock) for their start, end and event times. #23054 makes Sentry correct its clock for drift (e.g. after the device slept), so Effect spans could end up shifted by the drift relative to the Sentry spans around them. With this PR, an Effect span now starts on Sentry's clock, and its end and event times are converted by their offset from the span's start. This is the same per-span offset that OpenTelemetry's SDK uses. We also do this for our spans now, see #24903 for details.
The PR keeps Effect's durations and any end time passed explicitly via
span.end(time, exit). WithwithTracerTiming(false), Effect passes0, and we now use Sentry's clock instead of setting 1970 timestamps.