Repository navigation
Add a gea.designWidth manifest field - #3
skyturkish wants to merge 1 commit into
Conversation
|
All contributors have signed the CLA. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe manifest normalizes ChangesDesign width handling
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to This adds design-width normalization and validation to app manifests and reports it in app summaries. No merge-blocking risk was found. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
|
recheck |
2b3a6cb to
719501e
Compare
An app whose stylesheets are written in fixed px was laid out against one particular width -- the panel it was drawn for. Targets that render at an arbitrary size (a phone screen, a resizable desktop window) have had no way to learn that width, so they either pinned the app to a build-time ratio or followed the display density, and a layout drawn for a small panel ended up either magnified or stranded in a corner. designWidth records the logical CSS width the app was authored against. A shell divides its real surface width by it to get the device pixel ratio, and since the engine multiplies every CSS px by that ratio (ui::cssPixelLength), the design scales to whatever it lands on with no second set of stylesheets. This is deliberately not cssDevicePixelRatio: that one is a FIXED ratio a board declares about itself, while this is a property of the app, and the ratio it implies is different on every screen. Absent, each target keeps its own default, so an app that declares nothing builds exactly as before. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
719501e to
802823d
Compare
Adds a
gea.designWidthmanifest field: the logical CSS width an app's stylesheets were authored for. Shells that render at an arbitrary size (phones, resizable desktop windows) divide their real width by it to get the device pixel ratio, so a layout drawn for a small panel scales to fill the surface instead of being magnified or left in a corner.weatherdeclares 273.Related PRs (merge core first):
🤖 Generated with Claude Code
Summary by CodeRabbit