Skip to content

[devtools_extensions] Remove the deprecated --pwa-strategy flag from build_and_copy - #10027

Open
spydon wants to merge 1 commit into
flutter:masterfrom
spydon:remove-pwa-strategy
Open

spydon wants to merge 1 commit into
flutter:masterfrom
spydon:remove-pwa-strategy

Conversation

@spydon

@spydon spydon commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Fixes #10026

Removes the hardcoded --pwa-strategy=offline-first flag from the build_and_copy command in devtools_extensions. Flutter deprecated the flag in flutter/flutter#177613 (towards flutter/flutter#156910), so passing it now prints:

ERROR: ERROR: ERROR: The --pwa-strategy option is deprecated and will be removed in a future Flutter release.

and the build will fail outright once the flag is removed, the same way the removed --web-renderer flag broke build_and_copy in #8639.

No tests are added because the change only deletes an argument from the flutter build web invocation, and the command has no existing test coverage of its arguments. Verified by building the Flame DevTools extension with the modified command on Flutter 3.47.3 stable, which completes without the warning.

Pre-launch Checklist

General checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).

Issues checklist

Tests checklist

  • I added new tests to check the change I am making...
  • OR there is a reason for not adding tests, which I explained in the PR description.

AI-tooling checklist

  • I did not use any AI tooling in creating this PR.
  • OR I did use AI tooling, and...
    • I read the AI contributions guidelines and agree to follow them.
    • I reviewed all AI-generated code before opening this PR.
    • I understand and am able to discuss the code in this PR.
    • I have verifed the accuracy of any AI-generated text included in the PR description.
    • I commit to verifying the accuracy of any AI-generated code or text that I upload in response to review comments.

Feature-change checklist

  • This PR does not change the DevTools UI or behavior and...
    • I added the release-notes-not-required label or left a comment requesting the label be added (I cannot add labels, this PR needs the release-notes-not-required label).
  • OR this PR does change the DevTools UI or behavior and...
    • I added an entry to packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md.
    • I included before/after screenshots and/or a GIF demo of the new UI to my PR description.
    • I ran the DevTools app locally to manually verify my changes.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the deprecated --pwa-strategy flag from the build_and_copy command in packages/devtools_extensions and updates the CHANGELOG.md to reflect this change. There are no review comments to evaluate, and I have no feedback to provide.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[devtools_extensions] build_and_copy passes the deprecated --pwa-strategy flag

3 participants