Repository navigation
Conversation
Signed-off-by: lprnmns <manasalperen@gmail.com>
lprnmns
marked this pull request as ready for review
August 31, 2026 16:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public
CookieOptionstype accepts the cookiepriorityoption, but the internal session Cookie model dropped that value before callingreply.setCookie. As a result, validlow,medium, andhighvalues never produced aPriorityattribute.This preserves
priorityalongside the existing cookie properties and includes it in the serialized cookie options. A focused integration test verifies thatpriority: 'high'emitsPriority=High.Validation:
node --test --test-name-pattern='should set session cookie with priority' test/cookie.test.jsnpm run test && npm run benchmark --if-presentnpm run lintThe full suite passes with 129 unit tests, 47 TypeScript assertions, and 100% reported coverage. The change is backward-compatible for existing configurations: an undefined priority remains omitted, while already-typed valid values now reach the underlying cookie serializer.
No issue is linked; this was independently reproduced on current
main.Checklist
npm run test && npm run benchmark --if-present