Repository navigation
Conversation
fnmatch() lowercased both sides on every OS, so a README.md pattern also dropped readme.md while packing a build context. Use os.path.normcase, which is what this helper already documented. Windows still folds case. Fixes docker#3450 Signed-off-by: Dean Chen <862469039@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packing a build context folded dockerignore patterns to lowercase on every OS, so a
README.mdrule also droppedreadme.mdon Linux. BuildKit keeps that other file.fnmatch()now usesos.path.normcase, which is what the docstring already said. Windows still folds case.Fixes #3450