Don't shorten types when a superclass is outside the file - #3124
Open
kalayciburak wants to merge 1 commit into
Open
kalayciburak wants to merge 1 commit into
kalayciburak wants to merge 1 commit into
Conversation
shortenFullyQualifiedTypes runs without a classpath. A superclass in another file can declare a member type, so shortening a qualified name inside the subclass can resolve to that member instead. Leave those references qualified. A superclass declared in the same file is still visible, and unrelated names there are still shortened. Fixes diffplug#3117
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shortenFullyQualifiedTypesshortenedexternal.Typeinsideclass Child extends BasewhenBaselives in another file. The simple name then resolves to an inherited member type, and the file no longer compiles.The step has no classpath, so a supertype that is not in this file can contribute member types it cannot see. References inside that type stay qualified. A supertype declared in the same file is still visible: only a name that matches a declared type is left alone, and other names are still shortened.
java.lang.Objectdoes not count, because it has no member types.Fixes #3117
Test plan
./gradlew :testlib:test --tests com.diffplug.spotless.java.ShortenFullyQualifiedTypesStepTest— 36 tests, including the cross-file case that failed before the change./gradlew :lib:spotlessJavaCheck :testlib:spotlessJavaCheck