Repository navigation
Star handlers called without the event type as the first arg #2
Description
Activity
- changed the title
[-]Star handlers should be called with event type as the first arg[/-][+]Star handlers called without the event type as the first arg[/+]on Jan 15, 2017 heh! I only realized after publishing that I'd made the wrong call there but then tweeted the right one. Thanks for the PR.
just sorry for the offtopic... @oaleynik which is that theme that you are using? I'm new to Atom and trying to find some meaningful theme for syntax.
@tunnckoCore that's actually my editor - I commented with the setup in this issue (apparently people really like my editor setup haha).
Reacted by Simeon VincentHaha, great & thanks. I'll try the syntax theme. Few weeks on Atom and can't find meaningful theme, tried dozen but all are absolutely awful.
Reacted by Jason Miller@tunnckoCore yeah, that screenshot is the ctrl+c/ctrl+v from Twitter :)
Currently I use https://github.com/apex/apex-ui and https://github.com/apex/apex-syntax created by legendary @tj - I found it super "disruption free" because of absence of the color "noise."Some other themes I like include:
- Chester
- Github Atom Light
- Material
- Gloom
- One Dark Vivid
It of course depends on the mood, time of the day when I work, moon phase, etc.. :)
@developit very sorry for the offtopic :)
Reacted by Jason MillerOne Dark Vivid for life (though now I'm looking at Gloom)
@oaleynik holy shit, so clean and enough, I'll try it, because screenshot is not enough for me :) Thanks again.
So TJ is still so amazing person, haha.
very sorry for the offtopic :)
meh.. it happens some times 😆
Reacted by Oleh Aleinyk and Jason MillerBtw, a bit on topic.
What about that (fixes #2 - this, resolves #12, 197b and in bonus: you can access the
all)let ret = { all: {}, on (type, handler) { list(type).push(handler) return ret }, off (type, handler) { let e = list(type) e.splice(e.indexOf(handler) >>> 0, 1) return ret }, emit (type, event) { list(type).map((f) => f(event)) list('*').map((f) => f(type, event)) return ret } } let list = (type) => ret.all[type = type.toLowerCase()] || (ret.all[type] = []) module.exports = () => ret
Damn, I'm god? 🚀 179b with #8
let mitt = { all: {}, on (type, handler) { list(type).add(handler) return mitt }, off (type, handler) { list(type).delete(handler) return mitt }, emit (type, event) { list(type).forEach( f => f(event)) list('*').forEach( f => f(type, event)) return mitt } } let list = (type) => mitt.all[type = type.toLowerCase()] || (mitt.all[type] = new Set()) export default () => mitt
usage
var mitt = require('./dist/mitt') var ee = mitt() ee .on('*', (type, arg) => console.log('wildcard:', type, arg)) .on('foo', (arg) => console.log('foo1:', arg)) .on('foo', (arg) => console.log('foo2:', arg)) .on('bar', (arg) => console.log('bar:', arg)) .emit('foo', 123) .emit('bar', 444)
edit: so we freely can implement multiple args - we have huge room :D
@tunnckoCore your implementation returns the same instance for every
mitt()call, which means listeners are shared for all instances. It needs to return a new instance for eachmitt()call so it's not just a singleton.Hm. Actually, yea. I get some tests.
Reacted by Jason Miller
Looks like all star handlers should be called with
typeas first argument, aren't they?