fix: correct the stale 'jr is title vocabulary' comment in script_segment - #590
Merged
Merged
Conversation
…ment The ASCII-bail comment (written in #312) said period_joined_vocab reads "Smith.Jr." as a title because 'jr' is title vocabulary, and that "Smith.Jr. Anderson" gives title "Smith.Jr.". #296 took 'jr' out of TITLES, so both halves went false: the verdict is "suffix", and the leading form gives given "Smith.Jr.", family "Anderson", while a trailing "John Anderson Smith.Jr." gives suffix "Smith.Jr.". The comment now states the measured verdict and both outcomes, dated, and makes no claim about which stage decides the leading case. Its point -- the ASCII bail returns before any of it reaches the peel -- stands. No other copy of the claim exists in nameparser/, tests/ or docs/. Comment-only; no behavior change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #590 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 45 45
Lines 4220 4220
=======================================
Hits 4177 4177
Misses 43 43 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ASCII-bail comment in
nameparser/_pipeline/_script_segment.py, written in #312, said:#296 later took
jrout ofTITLES, so both halves are now false. Measured on master (2026-10-02):period_joined_vocab("Smith.Jr.", Lexicon.default())returns"suffix"."Smith.Jr. Anderson"gives givenSmith.Jr., familyAnderson, with no title."John Anderson Smith.Jr."gives suffixSmith.Jr..The comment now states the verdict and both outcomes, with the measurement date. Per AGENTS.md's rule on stage claims, it doesn't say which stage leaves the leading token as the given name; that wasn't measured. The comment's actual point is unchanged: the ASCII bail returns before any of this reaches the honorific peel.
A sweep of
nameparser/,tests/anddocs/found no other copy of the claim. This was found by a reviewer during #588's docs review.Comment-only; no behavior change.
ruff checkpasses, as do thescript_segmentstage tests andtest_doc_citations.🤖 Generated with Claude Code