Skip to content

fix: correct the stale 'jr is title vocabulary' comment in script_segment - #590

Merged
derek73 merged 1 commit into
masterfrom
fix/stale-jr-title-comment
Oct 3, 2026
Merged

derek73 merged 1 commit into
masterfrom
fix/stale-jr-title-comment

Conversation

@derek73

@derek73 derek73 commented Oct 3, 2026

Copy link
Copy Markdown
Owner

The ASCII-bail comment in nameparser/_pipeline/_script_segment.py, written in #312, said:

period_joined_vocab reads "Smith.Jr." as a title ('jr' is title vocabulary as well as suffix vocabulary), and where position allows, that wins -- "Smith.Jr. Anderson" gives title "Smith.Jr."

#296 later took jr out of TITLES, so both halves are now false. Measured on master (2026-10-02):

  • period_joined_vocab("Smith.Jr.", Lexicon.default()) returns "suffix".
  • "Smith.Jr. Anderson" gives given Smith.Jr., family Anderson, with no title.
  • "John Anderson Smith.Jr." gives suffix Smith.Jr..

The comment now states the verdict and both outcomes, with the measurement date. Per AGENTS.md's rule on stage claims, it doesn't say which stage leaves the leading token as the given name; that wasn't measured. The comment's actual point is unchanged: the ASCII bail returns before any of this reaches the honorific peel.

A sweep of nameparser/, tests/ and docs/ found no other copy of the claim. This was found by a reviewer during #588's docs review.

Comment-only; no behavior change. ruff check passes, as do the script_segment stage tests and test_doc_citations.

🤖 Generated with Claude Code

…ment

The ASCII-bail comment (written in #312) said period_joined_vocab reads
"Smith.Jr." as a title because 'jr' is title vocabulary, and that
"Smith.Jr. Anderson" gives title "Smith.Jr.". #296 took 'jr' out of
TITLES, so both halves went false: the verdict is "suffix", and the
leading form gives given "Smith.Jr.", family "Anderson", while a
trailing "John Anderson Smith.Jr." gives suffix "Smith.Jr.". The
comment now states the measured verdict and both outcomes, dated, and
makes no claim about which stage decides the leading case. Its point
-- the ASCII bail returns before any of it reaches the peel -- stands.
No other copy of the claim exists in nameparser/, tests/ or docs/.

Comment-only; no behavior change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@derek73 derek73 added the docs Documentation fixes and updates label Oct 3, 2026
@derek73 derek73 self-assigned this Oct 3, 2026
@codecov

codecov Bot commented Oct 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.98%. Comparing base (2f7a044) to head (afccc47).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #590   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files          45       45           
  Lines        4220     4220           
=======================================
  Hits         4177     4177           
  Misses         43       43           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@derek73
derek73 merged commit e95028d into master Oct 3, 2026
11 checks passed
@derek73
derek73 deleted the fix/stale-jr-title-comment branch October 3, 2026 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation fixes and updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant