Option to get None instead of empty string

Hey,

is there an option to get None instead of an empty string for the components? E.g.

>>> name = HumanName("1 & 2, 3 4 5, Mr.")
>>> name.title
None
>>>name.first
'3'

There is not. Currently it returns the value from " ".join([]), which is an empty string. It would be pretty easy to make it do that though. Of course, you could do it easily too with something like name.title or None, but maybe there's some case where that's inconvenient? Idk, maybe it would be fine to make it always return None instead of an empty string? I don't have a strong preference.

For instance when you store the name components in a database and you want to store that values as NULL and not as empty string, it's easier when the module directly returns None.

Turns out the change breaks a bunch of tests, mostly to do with string formatting, so I just added a configuration option for it, documented here:

http://nameparser.readthedocs.org/en/latest/modules.html#nameparser.config.Constants.empty_attribute_default

Maybe it's an idea to modify line 122: Do a .replace(CONSTANTS.empty_attribute_default, "") first; since you probably don't want to have an output like 'None John None Doe None (None)' when printing the hole name.

remove default attribute from formatted string (#44)

Thanks for the suggestion. I gave it a shot but my attempt doesn't pass the test. I made a branch and pull request: #45

Here's the failed Travis build:
https://travis-ci.org/derek73/python-nameparser/builds/117161574

I figured it out. It was a problem with the tests and me forgetting how to use my own software.

I posted the results of the tests when CONSTANTS.empty_attribute_default = None over on the pull request. Take a look and let me know if you think there's something better we could do or maybe it's all fine.

Thanks for you friendly support. I am now using this module for some days and it is quite nice.

The code changes looks fine.

Maybe they are all just problems with the tests, because its explicitly testing for '' instead of hn.C.empty_attribute_default?

I think you are right. Probably you should test for hn.C.empty_attribute_default instead.

Merge pull request #45 from derek73/44_none_default

Just released v0.3.15 that should take care of all this

docs(rules): topic-review amendments from the 1.x stink-test session …

Navigation Menu

Repository navigation

Option to get None instead of empty string #44

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Option to get None instead of empty string #44

Description

Activity

derek73 commented on Mar 18, 2016

Xennis commented on Mar 19, 2016

derek73 commented on Mar 19, 2016

Xennis commented on Mar 19, 2016

derek73 commented on Mar 19, 2016

derek73 commented on Mar 19, 2016

derek73 commented on Mar 19, 2016

Xennis commented on Mar 20, 2016

derek73 commented on Mar 21, 2016

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions