Skip to content

mailname same as recipient hostname fails #60

Description

@reedjc

My mailname as set to same as the recipient hostname.

mail(1) using dma complained like:
send-mail: no recipients
Can't send mail: sendmail process failed with error code 66

dma logged
Nov 17 18:26:37 work dma[4a11a1]: no recipients

See add_recp() in dma.c:

192         host = strrchr(it->addr, '@');
193         if (host != NULL &&
194             (strcmp(host + 1, hostname()) == 0 ||
195              strcmp(host + 1, "localhost") == 0)) {
196                 *host = 0;
197         }

So this undocumented (?) behavior hides the hostname (in it->addr).

My trivial workaround is to mix up the case of my mailname (since the above strcmp is case sensitive).

Please document this behavior or please consider removing it or having it optional.

Also while there, two different conditions can log "no recipients". Please change one so don't have potential for identical logging.

Activity

  1. corecode commented on Nov 18, 2018

    @corecode
    Owner

    what do you mean by mailname?

  2. reedjc commented on Nov 18, 2018

    @reedjc
    Author

    MAILNAME which is config.mailname set to a path and that file's value returned via util.c's hostname().

    By the way, I was looking at master branch, but I am running DragonFly Mail Agent v0.11 from Ubuntu package dma 0.11-1build1.

  3. corecode commented on Aug 30, 2019

    @corecode
    Owner

    how come it doesn't log invalid recipient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions