Skip to content

Console not persistent visible during relaunch #312

Closed
#315
Closed
Console not persistent visible during relaunch#312
#315

Description

@vinsworldcom
vinsworldcom
opened on Nov 14, 2023

As @rdipardo points out in mohzy83/NppMarkdownPanel#90, the NppTbData.pszModuleName must be assigned to the DLL file name in order for Notepad++ to remember persistence. It is not:

PythonScript/PythonScript/src/ConsoleDialog.cpp

Line 567 in 9256580

m_data->pszModuleName = _T("Python Script");

Cheers.

Activity

  1. chcg
    closed this as completedin #315on Nov 15, 2023

  2. chcg commented on Nov 15, 2023

    @chcg
    chcg
    on Nov 15, 2023
    Collaborator

    @vinsworldcom Thanks for forwarding this topic here and thanks @xomx for the PR.

  3. vinsworldcom commented on Nov 15, 2023

    @vinsworldcom
    vinsworldcom
    on Nov 15, 2023
    ContributorAuthor

    Just tested the artifact - works as expected for me with simple test leaving the window visible and closing - it's there on re-launch. Closing the window, it is not there on relaunch.

    Thank you @xomx for the complete PR and @chcg for merging so quickly!

    Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions