Repository navigation
Conversation
…se the VALID_NONCE() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
notroj
suggested changes
Oct 7, 2026
| crash = env.httpd_error_log.wait_for( | ||
| re.compile(r'.*exit signal Segmentation fault.*'), | ||
| start_pos, timeout=3) | ||
| assert not crash, "Server crashed processing truncated nonce" |
Collaborator
There was a problem hiding this comment.
This should be caught already for every pyhttpd test - the env.check_error_log wired up as a fixture in the top-level conftest.py - so I think it shouldn't be necessary to do manually
Author
There was a problem hiding this comment.
Hi @notroj thanks, you're absolutely right, I'll fix that
Author
|
Tested on fc43 and Windows |
PaulLodge
marked this pull request as ready for review
October 8, 2026 09:58
Collaborator
|
Thanks Paul! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com