Skip to content

fix: clear_shrink(0) on rows should reset to original size + single group by fixes in clear_shrink - #25914

Open
rluvaton wants to merge 2 commits into
apache:mainfrom
rluvaton:release-rows-on-clear-shrink
Open

rluvaton wants to merge 2 commits into
apache:mainfrom
rluvaton:release-rows-on-clear-shrink

Conversation

@rluvaton

Copy link
Copy Markdown
Member

Which issue does this PR close?

None

Rationale for this change

For the Row change: clear_shrink 0 should release all memory and return to the initial size so we can return to a memory footprint that we know we can hold (this was found in #24015)

For the rest of the single group by fixes, the clear shrink left the struct in inconsistent state

What changes are included in this PR?

clear memory in rows and reset forgotten fields

What is the testing strategy for this PR?

Unit tests since for the group by it is not reached by our code but still leave in consistent state and it is a public trait
for the rows, it came from other test start failing in #24015 so I just added unit test here as well

Are there any user-facing changes?

No

…roup by fixes in clear_shrink

the clear_shrink was only called after emit, so this is why the bug was not shown before
@codecov-commenter

codecov-commenter commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.30435% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.60%. Comparing base (6924c6a) to head (35d48e0).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...n/physical-plan/src/aggregates/group_values/row.rs 84.00% 4 Missing ⚠️
...gregates/group_values/single_group_by/primitive.rs 88.88% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25914      +/-   ##
==========================================
- Coverage   82.60%   82.60%   -0.01%     
==========================================
  Files        1144     1144              
  Lines      442793   442858      +65     
  Branches   442793   442858      +65     
==========================================
+ Hits       365779   365830      +51     
- Misses      54863    54871       +8     
- Partials    22151    22157       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-plan Changes to the physical-plan crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants