Skip to content

Whole snapshot chain is lost when the latest snapshot is deleted #9446

Closed
#9447
Closed
Whole snapshot chain is lost when the latest snapshot is deleted#9446
#9447
Assignees
JoaoJandre
Labels
Severity:BLOCKERaffects:4.19.0component:storage
Milestone
4.19.2

Description

@JoaoJandre
JoaoJandre
opened on Jul 25, 2024
ISSUE TYPE
  • Bug Report
COMPONENT NAME
Storage
CLOUDSTACK VERSION
4.19.0
4.19.1
4.19.2
main
CONFIGURATION

N/A

OS / ENVIRONMENT

Env with XenServer

SUMMARY

When deleting a snapshot on XenServer, all of its parents will be erased, causing data loss.

STEPS TO REPRODUCE
1. Create a VM
2. Take a volume snapshot (S1).
3. Access the VM and write some data, for example with: dd if=/dev/zero of=test bs=1M count=1000
4. Use sync to make sure data is written to disk
5. Take a second volume snapshot (S2).
6. Delete the last volume snapshot (S2).
EXPECTED RESULTS
Only the last volume snapshot (S2) is deleted.
ACTUAL RESULTS
On the UI, only the last volume snapshot (S2) is deleted. However, actually, the whole snapshot chain is deleted (S2 AND S1). This can be verified directly on storage or through the snapshot_store_ref table. Any operation with the deleted snapshot (S1) will fail.

Activity

  1. JoaoJandre
    added
    Severity:BLOCKER
    component:storage
    affects:4.19.0
    on Jul 25, 2024
  2. JoaoJandre
    self-assigned this
    on Jul 25, 2024
  3. JoaoJandre
    linked a pull request that will close this issueFix snapshot chain being deleted on XenServer #9447on Jul 25, 2024
  4. yadvr
    added this to the 4.19.2.0 milestone on Jul 26, 2024

  5. yadvr commented on Jul 26, 2024

    @yadvr
    yadvr
    on Jul 26, 2024
    Member

    @JoaoJandre do you know if this was a regression in 4.19(.1) or did it happen also with earlier versions?

  6. JoaoJandre commented on Jul 26, 2024

    @JoaoJandre
    JoaoJandre
    on Jul 26, 2024
    ContributorAuthor

    @rohityadavcloud this regression was introduced in 4.19.0.0 (#7873)

  7. yadvr
    modified the milestones: 4.19.2.0, 4.19.1.1 on Jul 29, 2024
  8. shwstppr
    added a commit that references this issue on Aug 1, 2024

    Fix snapshot chain being deleted on XenServer (#9447)

    9033ab7
  9. nvazquez
    added 2 commits that reference this issue on Aug 6, 2024

    [4.19] server, api, ui: access improvements and assorted fixes (#22)

    7cfbcf4

    [4.19] server, api, ui: access improvements and assorted fixes (#22)

    6fbdda9
  10. nvazquez
    closed this as completedin 9033ab7on Aug 6, 2024
  11. yadvr
    modified the milestones: 4.19.1.1, 4.19.2.0 on Aug 8, 2024
  12. dhslove
    added 2 commits that reference this issue on Aug 22, 2024

    Fix snapshot chain being deleted on XenServer (apache#9447)

    0fa57f5

    [4.19] server, api, ui: access improvements and assorted fixes (#22)

    514de6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Severity:BLOCKERaffects:4.19.0component:storage

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions