Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Update strings.js, merge new translates strings for latest version. - #5161

Merged
jasonsanjose merged 2 commits into
adobe:masterfrom
michaeljayt:master
Sep 12, 2013
Merged

jasonsanjose merged 2 commits into
adobe:masterfrom
michaeljayt:master

Conversation

@michaeljayt

Copy link
Copy Markdown
Contributor

I just used the latest Brackets Sprint 30 and found some missing translations. Hope that this commit can make the latest version better for the Simplified Chinese users.

@ghost ghost assigned jasonsanjose Sep 11, 2013
@jasonsanjose

Copy link
Copy Markdown
Member

@michaeljayt Thanks for the contribution. Please sign the contributor license agreement so that we can merge this pull request after it's reviewed http://dev.brackets.io/brackets-contributor-license-agreement.html.

@yodfz do you have time to review these changes to the Chinese translation?

Comment thread src/nls/zh-cn/strings.js Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing comma at the end of line 376 is causing the JSHint failures in the Travis CI build.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got that now. and I'll fix it ASAP, and what can I do with this pull request now?

@jasonsanjose

Copy link
Copy Markdown
Member

@michaeljayt Now we wait until someone reviews the translation. I've posted a request for help in our google group here https://groups.google.com/d/topic/brackets-dev/5NdxOeqSx4k/discussion. If you have any friends or colleagues that can help review, please feel free to recruit them. Thanks!

@yodfz

yodfz commented Sep 12, 2013

Copy link
Copy Markdown
Contributor

@jasonsanjose
@michaeljayt
Is ok!translation is very good!beatiful!

@michaeljayt

Copy link
Copy Markdown
Contributor Author

I thought that I should replace all the English punctuation to Chinese one, but have no time now...and for some words like 'live' in word 'Live Preview', The inconsistent translation '在线' and '实时' both exists in the strings.js...I wish that I could deal with these issues when I am free...

@jasonsanjose

Copy link
Copy Markdown
Member

Merging.

jasonsanjose added a commit that referenced this pull request Sep 12, 2013
Update strings.js, merge new translates strings for latest version.
@jasonsanjose
jasonsanjose merged commit c035593 into adobe:master Sep 12, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants