Skip to content
This repository was archived by the owner on Sep 2, 2021. It is now read-only.

Support for chromium browser in linux - #317

Merged
jasonsanjose merged 1 commit into
adobe:masterfrom
macie:linux-OpenLiveBrowser
Aug 30, 2013
Merged

jasonsanjose merged 1 commit into
adobe:masterfrom
macie:linux-OpenLiveBrowser

Conversation

@macie

@macie macie commented Aug 28, 2013

Copy link
Copy Markdown

Replaced execl() by execlp() and added support for chromium browser.

@ghost ghost assigned jasonsanjose Aug 28, 2013
@jasonsanjose

Copy link
Copy Markdown
Member

Thanks @macie. I'll get to this for Sprint 31. Sprint 30 closes down today.

I think this a good interim solution until we have a way to set the desired browser in preferences. Great work!

@hollec

hollec commented Aug 28, 2013

Copy link
Copy Markdown

I believe this will help fix brackets issue #4720. As part of this support, should CloseLiveBrowser also be updated? It references the process google-chrome. At least on Ubuntu 13.04, when launching Chrome via the menu, the process I have running is chrome, launched via /opt/google/chrome/chrome. The google-chrome executable is still located at /usr/bin/google-chrome.

@jasonsanjose

Copy link
Copy Markdown
Member

Yes, @macie we should also update CloseLiveBrowser to close the same instance that was opened.

@macie

macie commented Aug 29, 2013

Copy link
Copy Markdown
Author

@jasonsanjose I looked up the code, but unfortunatly I still don't know what CloseLiveBrowser does (where is used) and how to close it in smart way.

@jasonsanjose

Copy link
Copy Markdown
Member

@macie it's used if the user already has Chrome open, but without debugging enabled --remote-debugging-port=9222. If we're in that state, we close the running instance of chrome relaunch with debugging enabled.

@jasonsanjose

Copy link
Copy Markdown
Member

Looks good. Merging.

@jasonsanjose

Copy link
Copy Markdown
Member

Tested with Chromium 28 on Ubuntu 13.04 64-bit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants