Skip to content

fix: even out bridge card padding, APR chart line order and Supply button radius - #3118

Open
abjt14 wants to merge 1 commit into
mainfrom
abhijeet/ui-fix-bridge-padding-apr-chart-supply-radius
Open

abjt14 wants to merge 1 commit into
mainfrom
abhijeet/ui-fix-bridge-padding-apr-chart-supply-radius

Conversation

@abjt14

@abjt14 abjt14 commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

…tton radius

- Bridge GHO modal: every card now has 12px padding on all sides.
  - NetworkSelect: the v3 uplift dropped the theme's outlined-Select
    padding, so the Select fell back to MUI's 16.5px and the card's bottom
    ran ~24.5px against 8px on top. Card is now 12px top / 8px bottom and
    the Select 4px vertical / 12px left (12px below the row in total). The
    network row now lines up with the label instead of sitting 2px right.
  - AssetInput: the balance row's py: 2 was a no-op inside its fixed 16px
    border-box height, leaving 4px below "$0 / balance / Max" and clipping
    the 28px Max button. Swap it for a 12px bottom margin and raise the
    top from 8px to 12px. This is the shared amount input, so every
    modal's amount card gets the same fix (card is 12px taller).
  - BridgeDestinationInput: side padding 8px -> 12px.
  - BridgeModalContent: drop the empty spacer <Row /> that took the
    last-of-type margin reset away from "Estimated time" (bottom 28px ->
    12px). The fee-warning Alert state is unchanged.
- ApyGraph / MeritApyGraph: draw the dashed average line before the data
  line so the colored line sits on top. The "Avg x%" pill stays above it;
  its background is ~6% opaque, so under the line the stroke would cut
  through the text.
- ReserveActions: give the reserve-page Supply button size="medium".
  FunSupplyButton defaults to size="small", and this call site forced it
  to 36px tall without changing the size, so it kept the small 6px radius
  next to Borrow's 8px. Both now use the medium 8px radius like every
  other 36px button.
@odin-by-borg

odin-by-borg Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Mjolnir Security Review

VerdictCLEAN · 0 findings
Commitb31e462 · 6s

No security vulnerabilities identified in the reviewed changes. This PR is purely presentational: it adjusts padding and spacing on transaction input components, sets a button size, and reorders average-line versus label rendering in APY graphs. It has no effect on the security posture.

View in Odin


29 PRs reviewed · 1 finding

@vercel

vercel Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
interface Ready Ready Preview Oct 2, 2026 3:45am UTC

Request Review

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.34 MB (🟡 +22 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/reserve-overview 38.94 KB (🟡 +6 B) 1.38 MB
/sgho 92.63 KB (-2 B) 1.43 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

This branch was successfully deployed

1 active deployment
Preview — b31e4622 Deployed Oct 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants