🎨 Improved the layout of the Portal email preferences screen - #31125
weylandswart wants to merge 1 commit into
Conversation
ref https://linear.app/ghost/issue/DES-1242/portal-unsubscribe-screen-looks-shit The unsubscribe and email preferences screen had uneven spacing and a stack of footer text under the Unsubscribe button. The confirmation message now sits 20px under the title, "Not receiving emails?" is the last row of the list, and the paid subscription note sits directly under the button. Without the message, the title-to-list gap stays at 40px to match Portal's other detail screens. Copy and behaviour are unchanged.
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many -t test:unit -p @tryghost/portal |
✅ Succeeded | 1m 25s | View ↗ |
nx run ghost-monorepo:lint:boundaries |
✅ Succeeded | 30s | View ↗ |
nx run-many -t lint -p @tryghost/portal,ghost-m... |
✅ Succeeded | 10s | View ↗ |
nx run @tryghost/e2e:test:fixtures |
✅ Succeeded | 1s | View ↗ |
nx run @tryghost/admin:build |
✅ Succeeded | 7s | View ↗ |
nx run-many --target=build --projects=tag:publi... |
✅ Succeeded | 3s | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-09-30 10:17:03 UTC
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: TryGhost/Ghost/.coderabbit.yaml Review profile: QUIET Plan: Advanced Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (9)
🧰 Additional context used📓 Path-based instructions (6)These are independent public UMD/CDN surfaces, not embedded Shade apps.⚙️ CodeRabbit configuration file Files:
New source files must be TypeScript: flag new JS files as a required change unless exempt (DB migrations, apps/ember-admin/, tool/config files, scripts/, docker/, generated code).⚙️ CodeRabbit configuration file Files:
Prioritise concrete correctness, security, data-integrity, compatibility, and regression risks.⚙️ CodeRabbit configuration file Files:
Source excerpt: This extracts source strings, updates all locale files, and synchronizes `packages/i18n/locales/context.json`.📄 CodeRabbit inference engine (docs/practices/internationalization.md) Files:
Source excerpt: Built Admin assets are copied into `ghost/core/core/built/admin/` for the Ghost release.📄 CodeRabbit inference engine (docs/codebase/monorepo-structure.md) Files:
Source excerpt: Errors are part of the product experience.📄 CodeRabbit inference engine (docs/practices/error-handling.md) Files:
🔇 Additional comments (2)
WalkthroughThe email preferences view now displays the email-receiving FAQ link in the preferences list when email suppression is active and preferences are enabled. The notification appears before the close button. The paid-member message appears in the unsubscribe button container. Styles update the help row and unsubscribe note and remove secondary footer styling. Suggested reviewers: Priority: ⬇️ Low Change: Bug fix 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This branch has not been deployed
1 participant
Closes https://linear.app/ghost/issue/DES-1242/portal-unsubscribe-screen-looks-shit
Improves the look of the email preferences modal. Copy and behaviour are unchanged.