fix: Prevent trailing slash in example paths - #1311
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 3254ef1 | Commit Preview URL Branch Preview URL |
Sep 30 2026, 11:06 AM |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where navigating to an examples index page (e.g.,
/docs/react-query/latest/framework/react/examples) would result in a validation error.The root cause was that when the
_splatparameter was empty (meaning no specific example was selected), the[framework, params._splat].join('/')expression would produce a trailing slash (e.g.,react/). This trailing slash caused theisValidRepoPathvalibot validation to fail, leading to an unhandled error.The fix involves adding
.filter(Boolean)before.join('/')at all three affected locations insrc/routes/_library/$libraryId/$version.docs.framework.$framework.examples.$.tsx. This ensures that empty segments (like an empty_splat) are removed before joining, preventing the creation of a trailing slash and allowing the path to pass validation.Fixes TANSTACK-COM-1C5
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.