fix(pacer): Report retry outcomes and preserve failure details - #274
Draft
KevinVandy wants to merge 6 commits into
Draft
KevinVandy wants to merge 6 commits into
KevinVandy wants to merge 6 commits into
Conversation
Adapt the normalization fix from #223 and cover primitive, object, existing Error, and parent callback outcomes. Co-authored-by: theBGuy <60308670+theBGuy@users.noreply.github.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 0045992
☁️ Nx Cloud last updated this comment at |
Contributor
🚀 Changeset Version Preview1 package(s) bumped directly, 4 bumped as dependents. 🟩 Patch bumps
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
lastResulton non-success and keep successfulundefinedresults valid.onErrorandthrowOnError. Preserve standalone retryer timeout and rejection behavior. Normalize non-Error failures with readable messages and their original value ascause.pnpm testandpnpm run test:pr, all 330 tasks; core size is 7.63 kB against a 10 kB limit.Closes #247
Stacked on #271 to include its execution ownership fixes. Adapts the non-Error normalization fix from #223 by @theBGuy.
✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact