Skip to content

Futurize to add __future__ imports breaks pylint directives #588

Description

@amethystmarie

When running the futurize fixer libfuturize.fixes.fix_unicode_literals_import on a file with a pylint directive, the import is added prior to the pylint directive, which causes them to be ignored. This is true of all directives that don't match the specific regexes of encoding, docstrings and shebang that the future_import method checks for.

def future_import(feature, node):

Before:

# pylint: disable=import-error,invalid-name

import path
import system

Run: futurize --write --fix=libfuturize.fixes.fix_unicode_literals_import

After:

from __future__ import unicode_literals

# pylint: disable=import-error,invalid-name

import path
import system

If it skipped to the first non-commented, non-docstring line before inserting anything, it would fix this and any other directives that haven't been accounted for.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions