Skip to content

setinfo does not set modification time #64

Description

@jwnimmer-tri

The current implementation of fs_s3fs.S3FS.setinfo() just a call to self.getinfo() (presumably to validate the path name).

However, if the call to setinfo() was due to trying to set the modification time as per fs.base.FS.settimes(), then the result appears to be no change to the modification time.

Perhaps until modification-time updates are correctly set by s3fs, it should raise NotImplementedError in this case for now.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions