Skip to content

Feature/phase removal - #13

Closed
Jammy2211 wants to merge 1055 commits into
masterfrom
feature/phase_removal
Closed

Jammy2211 wants to merge 1055 commits into
masterfrom
feature/phase_removal

Conversation

@Jammy2211

Copy link
Copy Markdown
Collaborator

Not much here as its autoarray, but lead to a few refactors in the design of datasets.

@Jammy2211
Jammy2211 requested a review from rhayes777 March 31, 2021 09:11
theta_coordinate_to_profile = np.arctan2(
shifted_grid_2d[:, 0], shifted_grid_2d[:, 1]
) - np.radians(angle)
return np.vstack(

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would multiplying by radius after the vstack call have the same result but be fractionally more efficient and concise?

if include_name is None:
include_name = name

if getattr(self.visuals_1d, name) is not None:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could throw an attribute error? Unless you're confident the attribute will always exist

return grid_2d.Grid2DTransformed(grid=result, mask=self.mask)
return grid_2d.Grid2D(grid=result, mask=self.mask.to_mask_2d)

def structure_list_from_result_list(self, result_list: list):

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this function is totally necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants