Feature/positions analysis simplify - #117
Merged
Merged
Conversation
Jammy2211
requested review from
CKrawczyk,
Sketos,
caoxiaoyue,
qiuhan96,
rhayes777 and
samlange04
August 7, 2024 17:04
rhayes777
approved these changes
Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent updates by Rich enable point-source modeling to now work correctly in autolens.
This required the implementation of a Point Solver, which determines the multiple images of a strong lens by ray tracing triangles to the source-plane and tracking which regions of the image plane contain the point source. This solver is now tested and works well, and also supports JAX.
This PR updates the fitting functionality associated with point sources, including:
All new features are described in the
autolens_workspace.