Get-PSResource does not search in user context environment variable PSModulePath #889

Activity

1. Olav Rønnestad Birkeland (o-l-a-v)

   added

   Needs-Triage

   on Jan 12, 2023
2. alerickson

   removed

   Needs-Triage

   on Jan 18, 2023
3. alerickson

   modified the milestones: vNext, 3.0-Consider on Jan 18, 2023
4. alerickson

   added

   Area-Paths

   feature_request

   on Jan 18, 2023
5. o-l-a-v commented on Apr 1, 2024

   

   Olav Rønnestad Birkeland (o-l-a-v)

   on Apr 1, 2024

   Last edited by o-l-a-v

   ContributorAuthor

   More actions

   Here's the responsible code as far as I can see:

   PSResourceGet/src/code/Utils.cs

   Lines 993 to 1017 in b28fba0

   	// Find all potential resource paths
   	public static List<string> GetPathsFromEnvVarAndScope(
   	PSCmdlet psCmdlet,
   	ScopeType? scope)
   	{
   	GetStandardPlatformPaths(
   	psCmdlet,
   	out string myDocumentsPath,
   	out string programFilesPath);
   	List<string> resourcePaths = new List<string>();
   	if (scope is null || scope.Value is ScopeType.CurrentUser)
   	{
   	resourcePaths.Add(Path.Combine(myDocumentsPath, "Modules"));
   	resourcePaths.Add(Path.Combine(myDocumentsPath, "Scripts"));
   	}
   	if (scope.Value is ScopeType.AllUsers)
   	{
   	resourcePaths.Add(Path.Combine(programFilesPath, "Modules"));
   	resourcePaths.Add(Path.Combine(programFilesPath, "Scripts"));
   	}
   	return resourcePaths;
   	}

   Seems doable to add PSModulePath here?

   if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && scope is not null) {
       Environment.GetEnvironmentVariable(
           "PSModulePath",
           scope.Value is ScopeType.CurrentUser ? EnvironmentVariableTarget.User : EnvironmentVariableTarget.Machine
       );
   }

   I understand it's more complex than that. One must have tests etc.

   Is this one up for grabs, or do you not want environment variable PSModulePath to have any say?

   ---

   Edit: Here's a PowerShellers attempt. 😁

   Click to view

   if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && scope is not null) {
       string PSModulePath = Environment.GetEnvironmentVariable(
           "PSModulePath",
           scope.Value is ScopeType.CurrentUser ? EnvironmentVariableTarget.User : EnvironmentVariableTarget.Machine
       );
       if (string.IsNullOrEmpty(PSModulePath)) {
           psCmdlet.WriteVerbose("Found no value for PSModulePath given the scope.");
       }
       else {
           foreach (string element in PSModulePath.Split(Path.PathSeparator)) {
               if (Directory.Exists(element)) {
                   if (
                       string.Equals(
                           element.Split(Path.DirectorySeparatorChar).Last(),
                           "Modules",
                           StringComparison.OrdinalIgnoreCase
                       )
                   ) {
                       psCmdlet.WriteVerbose(
                           string.Format(
                               "'{0}' exists, adding it to 'resourcePaths'.",
                               element
                           )
                       );
                       resourcePaths.Add(element);
                       resourcePaths.Add(Path.Combine(Directory.GetParent(element).FullName, "Scripts"));
                   }
                   else {
                       psCmdlet.WriteVerbose(
                           string.Format(
                               "'{0}' exists but does not match expected pattern, not adding it to 'resourcePaths'.",
                               element
                           )
                       );
                   }
               }
               else {
                   psCmdlet.WriteVerbose(
                       string.Format(
                           "'{0}' does not exist, not adding it to 'resourcePaths'.",
                           element
                       )
                   );
               }
           }
       }
   }